A first attempt at checking the exit code from the checkers.

lcd047 · lcd047 · commit 8c05dbf16e90 · 2013-07-12T08:08:41.000+03:00
diff --git a/autoload/syntastic/util.vim b/autoload/syntastic/util.vim
@@ -175,7 +175,16 @@ function! syntastic#util#info(msg)
 endfunction
 
 function! syntastic#util#warn(msg)
+    echohl WarningMsg
     echomsg "syntastic: warning: " . a:msg
+    echohl None
+endfunction
+
+function! syntastic#util#error(msg)
+    execute "normal \<Esc>"
+    echohl ErrorMsg
+    echomsg "syntastic: error: " . a:msg
+    echohl None
 endfunction
 
 function! syntastic#util#deprecationWarn(msg)
diff --git a/plugin/syntastic.vim b/plugin/syntastic.vim
@@ -327,6 +327,7 @@ endfunction
 "   'subtype' - all errors will be assigned the given subtype
 "   'postprocess' - a list of functions to be applied to the error list
 "   'cwd' - change directory to the given path before running the checker
+"   'returns' - a list of valid exit codes for the checker
 function! SyntasticMake(options)
     call syntastic#util#debug('SyntasticMake: called with options: '. string(a:options))
 
@@ -377,6 +378,10 @@ function! SyntasticMake(options)
         call s:Redraw()
     endif
 
+    if has_key(a:options, 'returns') && index(a:options['returns'], v:shell_error) == -1
+        throw 'Syntastic: checker error'
+    endif
+
     if has_key(a:options, 'defaults')
         call SyntasticAddToErrors(errors, a:options['defaults'])
     endif
diff --git a/plugin/syntastic/checker.vim b/plugin/syntastic/checker.vim
@@ -36,8 +36,13 @@ function! g:SyntasticChecker.getName()
 endfunction
 
 function! g:SyntasticChecker.getLocList()
-    let list = self._locListFunc()
-    call syntastic#util#debug('getLocList: checker ' . self._filetype . '/' . self._name . ' returned ' . v:shell_error)
+    try
+        let list = self._locListFunc()
+        call syntastic#util#debug('getLocList: checker ' . self._filetype . '/' . self._name . ' returned ' . v:shell_error)
+    catch /\m\C^Syntastic: checker error$/
+        let list = []
+        call syntastic#util#error('checker ' . self._filetype . '/' . self._name . ' returned abnormal status ' . v:shell_error)
+    endtry
     call self._populateHighlightRegexes(list)
     return g:SyntasticLoclist.New(list)
 endfunction
diff --git a/syntax_checkers/c/checkpatch.vim b/syntax_checkers/c/checkpatch.vim
@@ -39,6 +39,7 @@ function! SyntaxCheckers_c_checkpatch_GetLocList()
     return SyntasticMake({
         \ 'makeprg': makeprg,
         \ 'errorformat': errorformat,
+        \ 'returns': [0],
         \ 'subtype': 'Style' })
 endfunction
 
diff --git a/syntax_checkers/c/sparse.vim b/syntax_checkers/c/sparse.vim
@@ -41,7 +41,8 @@ function! SyntaxCheckers_c_sparse_GetLocList()
     let loclist = SyntasticMake({
         \ 'makeprg': makeprg,
         \ 'errorformat': errorformat,
-        \ 'defaults': {'bufnr': bufnr("")} })
+        \ 'defaults': {'bufnr': bufnr("")},
+        \ 'returns': [0] })
     return loclist
 endfunction
 
diff --git a/syntax_checkers/html/tidy.vim b/syntax_checkers/html/tidy.vim
@@ -97,7 +97,8 @@ function! SyntaxCheckers_html_tidy_GetLocList()
     let loclist = SyntasticMake({
         \ 'makeprg': makeprg,
         \ 'errorformat': errorformat,
-        \ 'defaults': {'bufnr': bufnr("")} })
+        \ 'defaults': {'bufnr': bufnr("")},
+        \ 'returns': [0, 1, 2] })
 
     " filter out valid HTML5 from the errors
     for n in range(len(loclist))
diff --git a/syntax_checkers/html/w3.vim b/syntax_checkers/html/w3.vim
@@ -34,6 +34,7 @@ function! SyntaxCheckers_html_w3_GetLocList()
     let makeprg = 'curl -s -F output=json ' .
         \ '-F uploaded_file=@' . syntastic#util#shexpand('%:p') . '\;type=text/html ' .
         \ g:syntastic_html_w3_api
+
     let errorformat =
         \ '%A %\+{,' .
         \ '%C %\+"lastLine": %l\,%\?,' .
@@ -44,7 +45,12 @@ function! SyntaxCheckers_html_w3_GetLocList()
         \ '%C %\+"subtype": "%tarning"\,%\?,' .
         \ '%Z %\+}\,,' .
         \ '%-G%.%#'
-    let loclist = SyntasticMake({ 'makeprg': makeprg, 'errorformat': errorformat, 'defaults': {'bufnr': bufnr("")} })
+
+    let loclist = SyntasticMake({
+        \ 'makeprg': makeprg,
+        \ 'errorformat': errorformat,
+        \ 'defaults': {'bufnr': bufnr("")},
+        \ 'returns': [0] })
 
     for n in range(len(loclist))
         let loclist[n]['text'] = substitute(loclist[n]['text'], '\\\([\"]\)', '\1', 'g')
diff --git a/syntax_checkers/nroff/mandoc.vim b/syntax_checkers/nroff/mandoc.vim
@@ -31,7 +31,8 @@ function! SyntaxCheckers_nroff_mandoc_GetLocList()
 
     return SyntasticMake({
         \ 'makeprg': makeprg,
-        \ 'errorformat': errorformat })
+        \ 'errorformat': errorformat,
+        \ 'returns': [0, 2, 3, 4] })
 endfunction
 
 call g:SyntasticRegistry.CreateAndRegisterChecker({
diff --git a/syntax_checkers/perl/perlcritic.vim b/syntax_checkers/perl/perlcritic.vim
@@ -49,6 +49,7 @@ function! SyntaxCheckers_perl_perlcritic_GetLocList()
     let loclist = SyntasticMake({
         \ 'makeprg': makeprg,
         \ 'errorformat': errorformat,
+        \ 'returns': [0, 2],
         \ 'subtype': 'Style' })
 
     " change error types according to the prescribed threshold
diff --git a/syntax_checkers/pod/podchecker.vim b/syntax_checkers/pod/podchecker.vim
@@ -32,7 +32,8 @@ function! SyntaxCheckers_pod_podchecker_GetLocList()
 
     let loclist = SyntasticMake({
         \ 'makeprg': makeprg,
-        \ 'errorformat': errorformat })
+        \ 'errorformat': errorformat,
+        \ 'returns': [0, 1, 2] })
 
     for n in range(len(loclist))
         let e = loclist[n]
diff --git a/syntax_checkers/text/atdtool.vim b/syntax_checkers/text/atdtool.vim
@@ -42,6 +42,7 @@ function! SyntaxCheckers_text_atdtool_GetLocList()
     let loclist = SyntasticMake({
         \ 'makeprg': makeprg,
         \ 'errorformat': errorformat,
+        \ 'returns': [0],
         \ 'subtype': 'Style' })
 
     for n in range(len(loclist))
diff --git a/syntax_checkers/xhtml/tidy.vim b/syntax_checkers/xhtml/tidy.vim
@@ -72,7 +72,8 @@ function! SyntaxCheckers_xhtml_tidy_GetLocList()
     let loclist = SyntasticMake({
         \ 'makeprg': makeprg,
         \ 'errorformat': errorformat,
-        \ 'defaults': {'bufnr': bufnr("")} })
+        \ 'defaults': {'bufnr': bufnr("")},
+        \ 'returns': [0, 1, 2] })
 
     for n in range(len(loclist))
         if loclist[n]['valid'] && s:IgnoreError(loclist[n]['text']) == 1
diff --git a/syntax_checkers/xml/xmllint.vim b/syntax_checkers/xml/xmllint.vim
@@ -43,7 +43,8 @@ function! SyntaxCheckers_xml_xmllint_GetLocList()
 
     return SyntasticMake({
         \ 'makeprg': makeprg,
-        \ 'errorformat': errorformat })
+        \ 'errorformat': errorformat,
+        \ 'returns': [0, 1, 2, 3, 4, 5] })
 endfunction
 
 call g:SyntasticRegistry.CreateAndRegisterChecker({
