Scroll to the hash only if there's one after an error. (vercel#2224)

arunoda · timneutkens · commit 4726c4352efc · 2017-06-09T23:45:37.000+02:00
diff --git a/lib/app.js b/lib/app.js
@@ -44,12 +44,14 @@ class Container extends Component {
 
   scrollToHash () {
     const { hash } = this.props
+    if (!hash) return
+
     const el = document.getElementById(hash)
-    if (el) {
-      // If we call scrollIntoView() in here without a setTimeout
-      // it won't scroll properly.
-      setTimeout(() => el.scrollIntoView(), 0)
-    }
+    if (!el) return
+
+    // If we call scrollIntoView() in here without a setTimeout
+    // it won't scroll properly.
+    setTimeout(() => el.scrollIntoView(), 0)
   }
 
   shouldComponentUpdate (nextProps) {
