Fixed an issue where two-page sites didn't split code. (vercel#2329)

aickin · arunoda · commit 9c2db29166ba · 2017-06-21T09:57:24.000+05:30
diff --git a/server/build/webpack.js b/server/build/webpack.js
@@ -102,7 +102,12 @@ export default async function createCompiler (dir, { dev = false, quiet = false,
           return module.context && module.context.indexOf('node_modules') >= 0
         }
 
-        // Move modules used in at-least 1/2 of the total pages into commons.
+        // If there are one or two pages, only move modules to common if they are
+        // used in all of the pages. Otherwise, move modules used in at-least
+        // 1/2 of the total pages into commons.
+        if (totalPages <= 2) {
+          return count === totalPages
+        }
         return count >= totalPages * 0.5
       }
     }),

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,12 @@ export default async function createCompiler (dir, { dev = false, quiet = false,`
`102`	`102`	`return module.context && module.context.indexOf('node_modules') >= 0`
`103`	`103`	`}`
`104`	`104`
`105`		`- // Move modules used in at-least 1/2 of the total pages into commons.`
	`105`	`+ // If there are one or two pages, only move modules to common if they are`
	`106`	`+ // used in all of the pages. Otherwise, move modules used in at-least`
	`107`	`+ // 1/2 of the total pages into commons.`
	`108`	`+ if (totalPages <= 2) {`
	`109`	`+ return count === totalPages`
	`110`	`+ }`
`106`	`111`	`return count >= totalPages * 0.5`
`107`	`112`	`}`
`108`	`113`	`}),`