Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit db60bc0

Browse files
committed
thing
Signed-off-by: Adam Gutglick <[email protected]>
1 parent 49cce3b commit db60bc0

4 files changed

Lines changed: 10 additions & 6 deletions

File tree

docs/developer-guide/internals/session.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,9 +99,10 @@ For tests or specialized use-cases, sessions can be assembled from individual co
9999
the `.with::<T>()` builder:
100100

101101
```rust
102-
let session = VortexSession::empty()
102+
let session = VortexSession::builder()
103103
.with::<ArraySession>()
104104
.with::<LayoutSession>()
105105
.with::<ScalarFnSession>()
106-
.with::<RuntimeSession>();
106+
.with::<RuntimeSession>()
107+
.build();
107108
```

vortex-array/src/aggregate_fn/proto.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,9 +170,10 @@ mod tests {
170170

171171
#[test]
172172
fn unknown_aggregate_fn_id_allow_unknown() {
173-
let session = VortexSession::empty()
173+
let session = VortexSession::builder()
174174
.with::<AggregateFnSession>()
175-
.allow_unknown();
175+
.allow_unknown()
176+
.build();
176177

177178
let proto = pb::AggregateFn {
178179
id: "vortex.test.foreign_aggregate".to_string(),

vortex-array/src/lib.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ pub mod flatbuffers {
9393
/// additional encodings or kernels into it without affecting any other session. This does not
9494
/// register file, layout, or runtime state — those live in higher-level crates.
9595
pub fn array_session() -> VortexSession {
96-
VortexSession::empty()
96+
VortexSession::builder()
9797
.with::<ArraySession>()
9898
.with::<DTypeSession>()
9999
.with::<ScalarFnSession>()
@@ -102,6 +102,7 @@ pub fn array_session() -> VortexSession {
102102
.with::<AggregateFnSession>()
103103
.with::<ArrowSession>()
104104
.with::<MemorySession>()
105+
.build()
105106
}
106107

107108
// TODO(ngates): canonicalize doesn't currently take a session, therefore we cannot invoke execute

vortex-ipc/src/lib.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,9 @@ mod test {
2424
use vortex_session::VortexSession;
2525

2626
pub(crate) static SESSION: LazyLock<VortexSession> = LazyLock::new(|| {
27-
VortexSession::empty()
27+
VortexSession::builder()
2828
.with::<DTypeSession>()
2929
.with::<ArraySession>()
30+
.build()
3031
});
3132
}

0 commit comments

Comments
 (0)