ci(fuzz): fix self-cancelling concurrency in fuzzer autofix#8203
Merged
Conversation
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | chunked_varbinview_canonical_into[(1000, 10)] |
162.1 µs | 198 µs | -18.12% |
| ⚡ | Simulation | chunked_varbinview_canonical_into[(100, 100)] |
309.2 µs | 273.2 µs | +13.16% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing ji/fix-fuzzer-autofix-concurrency (2a4d715) with develop (326b475)
fuzzer-issue-autofix.yml (the issues-triggered caller) uses concurrency group `fuzzer-fix-<issue>` to collapse the duplicate opened+labeled events GitHub emits. The reusable fuzzer-fix-automation.yml used the *same* group name. Because a reusable workflow runs inside its caller's run, entering the identical group with cancel-in-progress made the fixer cancel its own parent: the run failed after the gate job with no fix job ever starting, and no fix PR was produced for issues filed via the label trigger. Namespace the reusable workflow's group as `fuzzer-fix-automation-<issue>` so it no longer collides with the caller. Direct workflow_dispatch invocations are still deduped per issue. Signed-off-by: Joe Isaacs <[email protected]>
d1c8662 to
2a4d715
Compare
robert3005
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Filing/labeling a fuzzer issue triggers
fuzzer-issue-autofix.yml, which calls the reusablefuzzer-fix-automation.yml. Both used the same concurrency group name,fuzzer-fix-<issue>:fuzzer-issue-autofix.yml:group: fuzzer-fix-${{ github.event.issue.number }}fuzzer-fix-automation.yml:group: fuzzer-fix-${{ inputs.issue_number || github.run_id }}A reusable workflow runs inside its caller's run. When the caller's
autofixjob invoked the reusable workflow, the callee entered the identical group withcancel-in-progress: trueand cancelled its own parent run.