Fix line-oriented callbacks

nya3jp · nya3jp · commit 3e0e546d5a89 · 2022-04-16T10:17:40.000+09:00
stdoutcb/stderrcb assume that an input string is a single line, but in fact it can contain multiple lines, or even be a part of a line. One of the consequence is that cocopa fails to parse compiler output when it contains long lines (microsoft#1275). This patch fixes the issue by introducing a buffer to accumulate received data before passing them to callbacks. Fixes microsoft#1275.
diff --git a/src/arduino/arduino.ts b/src/arduino/arduino.ts
@@ -746,7 +746,25 @@ export class ArduinoApp {
             }
             return ret;
         }
-        const stdoutcb = (line: string) => {
+
+        // Wrap line-oriented callbacks to accept arbitrary chunks of data.
+        const wrapLineCallback = (callback: (line: string) => void) => {
+            let buffer = "";
+            return (data: string) => {
+                buffer += data;
+                for (;;) {
+                    const pos = buffer.indexOf(os.EOL);
+                    if (pos < 0) {
+                        break;
+                    }
+                    const line = buffer.substring(0, pos + os.EOL.length);
+                    buffer = buffer.substring(pos + os.EOL.length);
+                    callback(line);
+                }
+            };
+        }
+
+        const stdoutcb = wrapLineCallback((line: string) => {
             if (cocopa.callback) {
                 cocopa.callback(line);
             }
@@ -758,8 +776,8 @@ export class ArduinoApp {
                     arduinoChannel.channel.append(line);
                 }
             }
-        }
-        const stderrcb = (line: string) => {
+        });
+        const stderrcb = wrapLineCallback((line: string) => {
             if (os.platform() === "win32") {
                 line = line.trim();
                 if (line.length <= 0) {
@@ -784,7 +802,7 @@ export class ArduinoApp {
                 }
             }
             arduinoChannel.channel.append(line);
-        }
+        });
 
         return await util.spawn(
             this._settings.commandPath,
