fix(server-renderer): simplify logic, remove two promises

deleteme · deleteme · commit e159b16ef3dc · 2024-08-19T19:02:08.000-07:00
diff --git a/packages/server-renderer/src/render.ts b/packages/server-renderer/src/render.ts
@@ -96,13 +96,10 @@ export function renderComponentVNode(
   const hasAsyncSetup = isPromise(res)
   let prefetches = instance.sp /* LifecycleHooks.SERVER_PREFETCH */
   if (hasAsyncSetup || prefetches) {
-    let p: Promise<unknown> = (
-      hasAsyncSetup
-        ? // instance.sp may be null until an async setup resolves, so evaluate it here
-          (res as Promise<void>).then(() => (prefetches = instance.sp))
-        : Promise.resolve()
-    )
+    const p: Promise<unknown> = Promise.resolve(res as Promise<void>)
       .then(() => {
+        // instance.sp may be null until an async setup resolves, so evaluate it here
+        prefetches = instance.sp
         if (prefetches) {
           return Promise.all(
             prefetches.map(prefetch => prefetch.call(instance.proxy)),
