fix(Transition): prevent unmounted block from being inserted after transition leave

edison1105 · edison1105 · commit f9a9fadc6d0e · 2025-12-22T17:47:23.000+08:00
diff --git a/packages/runtime-vapor/src/block.ts b/packages/runtime-vapor/src/block.ts
@@ -79,6 +79,7 @@ export function insert(
   parent: ParentNode & { $fc?: Node | null },
   anchor: Node | null | 0 = null, // 0 means prepend
   moveType: MoveType = MoveType.ENTER,
+  parentComponent?: VaporComponentInstance,
   parentSuspense?: any, // TODO Suspense
 ): void {
   anchor = anchor === 0 ? parent.$fc || _child(parent) : anchor
@@ -98,7 +99,15 @@ export function insert(
         action(
           block,
           (block as TransitionBlock).$transition as TransitionHooks,
-          () => parent.insertBefore(block, anchor as Node),
+          () => {
+            // if the component is unmounted after leave finish, remove the block
+            // to avoid retaining a detached node.
+            if (moveType === MoveType.LEAVE && parentComponent!.isUnmounted) {
+              block.remove()
+            } else {
+              parent.insertBefore(block, anchor as Node)
+            }
+          },
           parentSuspense,
         )
       } else {
diff --git a/packages/runtime-vapor/src/components/KeepAlive.ts b/packages/runtime-vapor/src/components/KeepAlive.ts
@@ -359,7 +359,7 @@ export function deactivate(
   instance: VaporComponentInstance,
   container: ParentNode,
 ): void {
-  insert(instance.block, container, null, MoveType.LEAVE)
+  insert(instance.block, container, null, MoveType.LEAVE, instance)
 
   queuePostFlushCb(() => {
     if (instance.da) invokeArrayFns(instance.da)
