Size Report

Bundles

Usages

Could someone please run the ecosystem-cI? Thanks!

/ecosystem-ci run

📝 Ran ecosystem CI: Open

The vueuse build failed in ecosystem-ci because vueuse maintains its own definitions of MaybeRef and MaybeRefOrGetter, and there are mixed uses of locally defined types and types imported from vue-demi, leading to type compatibility issues.

I fixed this issue in PR #4099.

A similar issue was fixed for ComputedRef<T> in #8748

I think the fix should be consistent to make MaybeRef<T> also include ComputedRef<T> (and remove ComputedRef<T> from unref's argument union)

A similar issue was fixed for ComputedRef<T> in #8748.

I think the fix should be consistent to make MaybeRef<T> also include ComputedRef<T> and remove ComputedRef<T> from unref's argument union.

According to the test case below, MaybeRef seems to be writable (ref this comment):

Should we change this behavior?

In this case changing MaybeRef seems to technically be a type-level breaking change, and we should only do it in 3.5.

For now the immediate fix for #11356 should be just adding ShallowRef to the unref argument union.

In this case changing MaybeRef seems to technically be a type-level breaking change, and we should only do it in 3.5.

For now the immediate fix for #11356 should be just adding ShallowRef to the unref argument union.

Updated.

Based on you feedback, would it be reasonable to submit a PR to the minor branch with the following fix (this will not break the existing test)?

export type MaybeRef<T = any> = T | Ref<T> | ShallowRef<T> | WritableComputedRef<T>
export type MaybeRefOrGetter<T = any> = MaybeRef<T> | (() => T)

Based on you feedback, would it be reasonable to submit a PR to the minor branch with the following fix

Yes please.