Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(kit): avoid circular vue instance ref when encoding state #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 14, 2024

Conversation

alexzhang1030
Copy link
Member

@alexzhang1030 alexzhang1030 commented Jun 7, 2024

closes #420

Encoding Vue Instance logic -> Before(Maybe infinite loop):

Untitled.mp4

Encoding Vue instance logic -> After:

Untitled.mp4

Preview changes:

iShot_2024-06-13_20 17 36

@alexzhang1030 alexzhang1030 requested a review from webfansplz June 7, 2024 07:55
Copy link

netlify bot commented Jun 7, 2024

Deploy Preview for vue-devtools-docs ready!

Name Link
🔨 Latest commit 1b6d787
🔍 Latest deploy log https://app.netlify.com/sites/vue-devtools-docs/deploys/666c6fe09ec1bc000812c949
😎 Deploy Preview https://deploy-preview-429--vue-devtools-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alexzhang1030 alexzhang1030 marked this pull request as draft June 7, 2024 08:58
@alexzhang1030 alexzhang1030 marked this pull request as ready for review June 13, 2024 08:55
@webfansplz webfansplz changed the title fix(core): avoid circular vue instance ref when encoding state fix(kit): avoid circular vue instance ref when encoding state Jun 14, 2024
@webfansplz webfansplz merged commit 7c32103 into vuejs:main Jun 14, 2024
5 checks passed
@alexzhang1030 alexzhang1030 deleted the fix/circular-ref branch June 16, 2024 14:27
jgaehring added a commit to jgaehring/farm-flow-board that referenced this pull request Jul 10, 2024
jgaehring added a commit to jgaehring/farm-flow-board that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maximum call stack size exceeded
2 participants