refactor(vscode, language-server): remove hybrid mode configuration #5248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vue-component-meta
vue-component-type-helpers
@vue/language-core
@vue/language-plugin-pug
@vue/language-server
vue-tsc
@vue/language-service
@vue/typescript-plugin
commit: |
machty
reviewed
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the 3.0 refactoring, the VSCode extension and language server no longer provide a configuration option to disable hybrid mode, which greatly reduces the amount of code to maintain, and this reduces the need for fs hacks on the
typescript-language-featurescode. Our ultimate goal is to eliminate the need for fs hacks altogether, so this is an important progress.Since language-server only works with typescript-plugin now, the test infrastructure needs to be refactored to run against
@vue/typescript-plugin, which we do based on typescript-server-harness.The test time has increased considerably for the time being, and this will be addressed in #5252 that removes the named pipe.