fix(vscode): make sure tsserver loads @vue/typescript-plugin last
#5483
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vue-component-meta
vue-component-type-helpers
@vue/language-core
@vue/language-plugin-pug
@vue/language-server
@vue/language-service
vue-tsc
@vue/typescript-plugin
commit: |
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that the Vue TypeScript plugin is always placed last in the tsserver plugin load order for VSCode.
- Adds a
.sort()call to the patchedreadFileSyncoutput so that"vue-typescript-plugin-pack"is ordered at the end. - Updates the VSCode extension’s
index.tsto inject the sorting logic whenever--globalPluginsis loaded.
Comments suppressed due to low confidence (2)
extensions/vscode/index.ts:202
- There’s no existing test to verify that the Vue plugin is moved to the end. Consider adding a unit test for the patched output to ensure the sort behavior works as intended.
// sort plugins for johnsoncodehk.tsslint, zardoy.ts-essential-plugins
extensions/vscode/index.ts:206
- The hardcoded plugin identifier here (
"vue-typescript-plugin-pack") may not match the actual package name (e.g.@vue/typescript-plugin). Verify the correct plugin.name value or reference it dynamically to ensure the sort actually applies.
s + '.sort((a,b)=>(b.name==="vue-typescript-plugin-pack"?-1:0)-(a.name==="vue-typescript-plugin-pack"?-1:0))',
Ilanaya
added a commit
to zardoy/typescript-vscode-plugins
that referenced
this pull request
Jul 6, 2025
Vue Official made patching plugin order on their side. See issue - vuejs/language-tools#5483, discord thread - https://discord.com/channels/325477692906536972/1391386265986793564
This was referenced Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compatibility with https://github.com/zardoy/typescript-vscode-plugins, refs: #4709.