fix(useStorage): fix undefined defaults (#3597)

Doctor-wu · web-flow · commit 042207883daa · 2023-12-04T11:41:16.000+01:00
diff --git a/packages/core/useStorage/index.test.ts b/packages/core/useStorage/index.test.ts
@@ -113,6 +113,17 @@ describe('useStorage', () => {
     expect(storedValue).toBeFalsy()
   })
 
+  it('undefined value', () => {
+    storage.removeItem(KEY)
+
+    const store = useStorage(KEY, undefined, storage)
+    const storedValue = storage.getItem(KEY)
+
+    expect(store.value).toBe(undefined)
+    expect(storage.getItem(KEY)).toBe(undefined)
+    expect(storedValue).toBeFalsy()
+  })
+
   it('remove value', async () => {
     storage.setItem(KEY, 'random')
 
diff --git a/packages/core/useStorage/index.ts b/packages/core/useStorage/index.ts
@@ -231,7 +231,7 @@ export function useStorage<T extends(string | number | boolean | object | null)>
       : storage!.getItem(key)
 
     if (rawValue == null) {
-      if (writeDefaults && rawInit !== null)
+      if (writeDefaults && rawInit != null)
         storage!.setItem(key, serializer.write(rawInit))
       return rawInit
     }

Original file line number	Diff line number	Diff line change
`@@ -231,7 +231,7 @@ export function useStorage<T extends(string \| number \| boolean \| object \| null)>`
`231`	`231`	`: storage!.getItem(key)`
`232`	`232`
`233`	`233`	`if (rawValue == null) {`
`234`		`- if (writeDefaults && rawInit !== null)`
	`234`	`+ if (writeDefaults && rawInit != null)`
`235`	`235`	`storage!.setItem(key, serializer.write(rawInit))`
`236`	`236`	`return rawInit`
`237`	`237`	`}`