fix(reactiveComputed): computed fn should be ComputedGetter (#4528)

OrbisK · web-flow · commit bea3184cbef5 · 2025-01-27T16:01:13.000Z
diff --git a/packages/shared/reactiveComputed/index.test.ts b/packages/shared/reactiveComputed/index.test.ts
@@ -53,4 +53,28 @@ describe('reactiveComputed', () => {
     expect(dummy).toBe(1)
     expect(type).toBe('foo')
   })
+
+  it('should allow for previous value access (for vue 3.4+)', () => {
+    const test = ref(0)
+
+    const obj = reactiveComputed<{ test: number, num: number }>(
+      prev => ({ test: test.value, num: (prev?.num ?? 2) }),
+    )
+
+    obj.num = 5
+    expect(obj).toMatchInlineSnapshot(`
+      {
+        "num": 5,
+        "test": 0,
+      }
+    `)
+
+    test.value = 1
+    expect(obj).toMatchInlineSnapshot(`
+      {
+        "num": 5,
+        "test": 1,
+      }
+    `)
+  })
 })
diff --git a/packages/shared/reactiveComputed/index.ts b/packages/shared/reactiveComputed/index.ts
@@ -1,10 +1,10 @@
-import type { UnwrapNestedRefs } from 'vue'
+import type { ComputedGetter, UnwrapNestedRefs } from 'vue'
 import { computed } from 'vue'
 import { toReactive } from '../toReactive'
 
 /**
  * Computed reactive object.
  */
-export function reactiveComputed<T extends object>(fn: () => T): UnwrapNestedRefs<T> {
+export function reactiveComputed<T extends object>(fn: ComputedGetter<T>): UnwrapNestedRefs<T> {
   return toReactive(computed(fn))
 }
