Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(useCountdown): new function #4125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 22, 2025
Merged

Conversation

rtugeek
Copy link
Contributor

@rtugeek rtugeek commented Aug 1, 2024

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

Add a useCountdown function for simple number countdown scenarios. A classic use case: SMS verification code resend countdown.

  • It's just a wrapper around useIntervalFn, and requestAnimationFrame is not used.
  • Controls are not implemented for now, as most countdown scenarios require Controls.

Additional context

#1035 (comment)

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. new function labels Aug 1, 2024
rtugeek added 2 commits August 1, 2024 12:40
2.Increase delay time for promiseTimeout in test cases
@reslear
Copy link
Contributor

reslear commented Jan 2, 2025

any news?

@OrbisK OrbisK requested a review from huang-julien January 14, 2025 08:10
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 14, 2025
@antfu antfu added this pull request to the merge queue Jan 22, 2025
Merged via the queue into vueuse:main with commit 69cedd2 Jan 22, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer new function size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants