Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(useSortable): wrong order of elements #4332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Conversation

ilyaliao
Copy link
Member

@ilyaliao ilyaliao commented Nov 9, 2024

fix: #4222 #3724

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

This PR fixes the discrepancy between the DOM order and the array order.

Steps to Reproduce the Error

a -> b -> c
a -> c -> b
c -> b -> a

The implementation references vue-draggable-plus, but has been slightly adjusted to avoid too many breaking changes.

Before this PR is merged, you can use key to force Vue to update the view. Here is an example

<script setup lang="ts">
import { ref } from 'vue'
import { useSortable } from '.'

const el = ref<HTMLElement | null>(null)
const list = ref([{ id: 1, name: 'a' }, { id: 2, name: 'b' }, { id: 3, name: 'c' }])

useSortable(el, list, {
  animation: 150,
})
</script>

<template>
  <div ref="el" class="flex flex-col gap-2 p-4 w-300px h-200px m-auto bg-gray-500/5 rounded">
    <div v-for="(item, index) in list" :key="`${item.id}-${index}`" class="h20 bg-gray-500/5 rounded p-3">
      {{ item.name }}
    </div>
  </div>
  <div class="text-center">
    {{ JSON.stringify(list) }}
  </div>
</template>

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 9, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Nov 9, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 21, 2024
@antfu antfu added this pull request to the merge queue Nov 21, 2024
Merged via the queue into vueuse:main with commit 9e78eda Nov 21, 2024
8 checks passed
@ilyaliao ilyaliao deleted the fix/issue-4222 branch November 21, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useSortable: wrong order of elements
2 participants