-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
fix(useMouse): check for MouseEvent
instead of Touch
to work with FF
#4457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MouseEvent
instead of Touch to work with FFMouseEvent
instead of Touch
to work with FF
5 tasks
huang-julien
previously approved these changes
Jan 5, 2025
antfu
previously approved these changes
Jan 10, 2025
Can you help to check the tests? Thanks |
Sure. I was waiting for vitest@v3. 👍🏽 Give me one hour 😄 NVM: you mean the current error. This is fixed. The current demo test does not detect the console.error. |
The initial bug is fixed (from tests) and I have rewritten the test so that it should fail with the old implementation. |
7 tasks
antfu
previously approved these changes
Feb 12, 2025
antfu
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
fixes #123
).Description
fixes #4454
This PR checks for MouseEvent instead of Touch. Firefox partially supports touch > "This interface is only exposed if a touch input device is detected".
Note
Browser tests currently do not cover console errors + do not run for Firefox in CI. WIP: -> done 19156ba
Additional context
Firefox caniuse:
