Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(useMouse): check for MouseEvent instead of Touch to work with FF #4457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 12, 2025

Conversation

OrbisK
Copy link
Collaborator

@OrbisK OrbisK commented Jan 3, 2025

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

fixes #4454

This PR checks for MouseEvent instead of Touch. Firefox partially supports touch > "This interface is only exposed if a touch input device is detected".

Note

Browser tests currently do not cover console errors + do not run for Firefox in CI. WIP: -> done 19156ba

Additional context

Firefox caniuse:
image

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 3, 2025
@OrbisK OrbisK changed the title fix(useMouse): check for MouseEvent instead of Touch to work with FF fix(useMouse): check for MouseEvent instead of Touch to work with FF Jan 3, 2025
huang-julien
huang-julien previously approved these changes Jan 5, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 5, 2025
antfu
antfu previously approved these changes Jan 10, 2025
@OrbisK OrbisK requested a review from antfu January 16, 2025 14:52
@antfu
Copy link
Member

antfu commented Jan 22, 2025

Can you help to check the tests? Thanks

@OrbisK
Copy link
Collaborator Author

OrbisK commented Jan 22, 2025

Can you help to check the tests? Thanks

Sure. I was waiting for vitest@v3. 👍🏽 Give me one hour 😄

NVM: you mean the current error. This is fixed. The current demo test does not detect the console.error.

@OrbisK
Copy link
Collaborator Author

OrbisK commented Jan 22, 2025

Can you help to check the tests? Thanks

The initial bug is fixed (from tests) and I have rewritten the test so that it should fail with the old implementation.

antfu
antfu previously approved these changes Feb 12, 2025
@antfu antfu added this pull request to the merge queue Feb 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 12, 2025
@antfu antfu added this pull request to the merge queue Feb 12, 2025
Merged via the queue into vueuse:main with commit ce9e5d7 Feb 12, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

BUG | usePointerLock | Demo doesn't work properly in Firefox
3 participants