Validate timetravel#201
Draft
charles-cooper wants to merge 2 commits into
Draft
Conversation
bail out if negative
|
|
||
| self.evm.patch.timestamp += seconds | ||
| self.evm.patch.block_number += blocks | ||
| if (new_blknum := self.evm.patch.block_number + blocks) < 0: |
Contributor
There was a problem hiding this comment.
Do we really need to abbreviate?
Member
Author
There was a problem hiding this comment.
no 🤓 but i think abbreviations are fine for variables with small scope! when i read code, i associate scope with size of the variable name, if the variable name is too long i start hunting for references to it outside of its actual scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Description for the changelog
Cute Animal Picture