Use [Exposed=Window]#438
Merged
Merged
Conversation
markafoltz
approved these changes
Sep 15, 2017
| [SecureContext, | ||
| Constructor(DOMString type, PresentationConnectionAvailableEventInit eventInitDict)] | ||
| [Constructor(DOMString type, PresentationConnectionAvailableEventInit eventInitDict), | ||
| SecureContext, Exposed=Window] |
Contributor
There was a problem hiding this comment.
Nit: Add a space to align indent with previous line.
c90f956 to
72cfca6
Compare
Member
Author
|
@mfoltzgoogle thanks for the review. I squashed the fix into the single commit 72cfca6 to keep the history clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
whatwg/webidl#365
Fix #437
Preview | Diff