images: don't try to clip <image> is clip axes are blank

etpinard · etpinard · commit 7107c07359d0 · 2016-08-23T10:16:36.000-04:00
- looks like the browsers ignored clip paths that have
  corresponding no &lt;defs&gt; item, but not all renders can
  support them (e.g. Batik - which lead to eps and pdf export
  failures).
diff --git a/src/components/images/draw.js b/src/components/images/draw.js
@@ -94,7 +94,6 @@ module.exports = function draw(gd) {
     }
 
     function applyAttributes(d) {
-
         var thisImage = d3.select(this);
 
         // Axes if specified
@@ -142,7 +141,9 @@ module.exports = function draw(gd) {
             yId = yref ? yref._id : '',
             clipAxes = xId + yId;
 
-        thisImage.call(Drawing.setClipUrl, 'clip' + fullLayout._uid + clipAxes);
+        if(clipAxes) {
+            thisImage.call(Drawing.setClipUrl, 'clip' + fullLayout._uid + clipAxes);
+        }
     }
 
 

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,6 @@ module.exports = function draw(gd) {`
`94`	`94`	`}`
`95`	`95`
`96`	`96`	`function applyAttributes(d) {`
`97`		`-`
`98`	`97`	`var thisImage = d3.select(this);`
`99`	`98`
`100`	`99`	`// Axes if specified`
`@@ -142,7 +141,9 @@ module.exports = function draw(gd) {`
`142`	`141`	`yId = yref ? yref._id : '',`
`143`	`142`	`clipAxes = xId + yId;`
`144`	`143`
`145`		`- thisImage.call(Drawing.setClipUrl, 'clip' + fullLayout._uid + clipAxes);`
	`144`	`+ if(clipAxes) {`
	`145`	`+ thisImage.call(Drawing.setClipUrl, 'clip' + fullLayout._uid + clipAxes);`
	`146`	`+ }`
`146`	`147`	`}`
`147`	`148`
`148`	`149`