fix(jasmine-framework): move @types/jasmine to dependencies (#15001)

mccmrunal · bgrozev · web-flow · commit e5df2d13c7f2 · 2026-01-17T09:53:09.000-08:00
* fix(jasmine-framework): move @types/jasmine to dependencies Fixes #14475 * fix: Allow specFileRetries to be overriden in the beforeSession hook (#14859) This fixes #14842. This initializes the launcher's specFileRetries to -1 instead of reading from the config. The worker then reads the value from the config after running the beforeSession hook, and includes the value in the "sessionStarted" message, which is then passed back to the launcher when the worker ends. * updated pnpm-lock --------- Co-authored-by: bgrozev <boris@jitsi.org>
diff --git a/packages/wdio-jasmine-framework/package.json b/packages/wdio-jasmine-framework/package.json
@@ -34,6 +34,7 @@
     "url": "https://github.com/webdriverio/webdriverio/issues"
   },
   "dependencies": {
+    "@types/jasmine": "^5.1.13",
     "@types/node": "^20.1.0",
     "@wdio/globals": "workspace:*",
     "@wdio/logger": "workspace:*",
@@ -42,7 +43,6 @@
     "jasmine": "^5.0.0"
   },
   "devDependencies": {
-    "@types/jasmine": "5.1.13",
     "expect-webdriverio": "^5.3.4"
   },
   "peerDependencies": {
diff --git a/packages/wdio-sauce-service/src/service.ts b/packages/wdio-sauce-service/src/service.ts
@@ -113,8 +113,10 @@ export default class SauceService implements Services.ServiceInstance {
          * This tweak allows us to set the real suite name for jasmine jobs.
          */
         /* istanbul ignore if */
-        if (this._suiteTitle === 'Jasmine__TopLevel__Suite') {
-            this._suiteTitle = test.fullName.slice(0, test.fullName.indexOf(test.description || '') - 1)
+        /* istanbul ignore if */
+        if (this._suiteTitle === 'Jasmine__TopLevel__Suite' && test.fullName) {
+            const descriptionIndex = test.fullName.indexOf(test.description || '')
+            this._suiteTitle = descriptionIndex > 0 ? test.fullName.slice(0, descriptionIndex - 1) : test.title || this._suiteTitle
         }
 
         if (this._browser && !this._isJobNameSet) {
diff --git a/packages/wdio-sauce-service/tests/service.test.ts b/packages/wdio-sauce-service/tests/service.test.ts
@@ -1068,6 +1068,81 @@ test('setAnnotation for VDC and RDC with multi remote', async () => {
     expect(browserChromeC.executeScript).toBeCalledWith('sauce:context=foo', [])
 })
 
+test('beforeTest should not throw if fullName is undefined (Jasmine hook)', async () => {
+    const service = new SauceService({}, {}, { user: 'foobar', key: '123' } as any)
+    service['_browser'] = browser
+    service['_suiteTitle'] = 'Jasmine__TopLevel__Suite'
+
+    // Simulate a test object that lacks fullName, which reportedly happens in some Jasmine hooks
+    const testObj = {
+        description: 'some test',
+        // fullName is missing or undefined
+    } as any
+
+    // This should NOT throw "TypeError: Cannot read properties of undefined (reading 'slice')" anymore
+    await expect(service.beforeTest(testObj)).resolves.not.toThrow()
+})
+
+test('beforeTest should fallback to title if description is missing in fullName (Jasmine)', async () => {
+    const service = new SauceService({}, {}, { user: 'foobar', key: '123' } as any)
+    service['_browser'] = browser
+    service['_suiteTitle'] = 'Jasmine__TopLevel__Suite'
+
+    const testObj = {
+        fullName: 'My Suite My Test',
+        description: undefined, // description missing
+        title: 'My Test'
+    } as any
+
+    await service.beforeTest(testObj)
+    // Fallback to test.title or keep existing suite title if extraction fails
+    expect(service['_suiteTitle']).toBe('My Test')
+})
+
+test('beforeTest should fallback to title if description is not found in fullName (Jasmine)', async () => {
+    const service = new SauceService({}, {}, { user: 'foobar', key: '123' } as any)
+    service['_browser'] = browser
+    service['_suiteTitle'] = 'Jasmine__TopLevel__Suite'
+
+    const testObj = {
+        fullName: 'My Suite My Test',
+        description: 'Other Test', // description not in fullName
+        title: 'My Test'
+    } as any
+
+    await service.beforeTest(testObj)
+    expect(service['_suiteTitle']).toBe('My Test')
+})
+
+test('beforeTest should keep existing suite title if extraction fails and no test title (Jasmine)', async () => {
+    const service = new SauceService({}, {}, { user: 'foobar', key: '123' } as any)
+    service['_browser'] = browser
+    service['_suiteTitle'] = 'Jasmine__TopLevel__Suite'
+
+    const testObj = {
+        fullName: 'My Suite My Test',
+        description: 'Other Test',
+        // no title
+    } as any
+
+    await service.beforeTest(testObj)
+    expect(service['_suiteTitle']).toBe('Jasmine__TopLevel__Suite')
+})
+
+test('beforeTest should correctly extract suite title when description is present (Jasmine Happy Path)', async () => {
+    const service = new SauceService({}, {}, { user: 'foobar', key: '123' } as any)
+    service['_browser'] = browser
+    service['_suiteTitle'] = 'Jasmine__TopLevel__Suite'
+
+    const testObj = {
+        fullName: 'My Suite My Test',
+        description: 'My Test'
+    } as any
+
+    await service.beforeTest(testObj)
+    expect(service['_suiteTitle']).toBe('My Suite')
+})
+
 afterEach(() => {
     // @ts-ignore
     browser = undefined
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
