fix: mangle destruction incorrect with export named default

alexander-akait · web-flow · commit 71ce86356996 · 2024-08-14T19:14:31.000+03:00
diff --git a/lib/dependencies/HarmonyImportSpecifierDependency.js b/lib/dependencies/HarmonyImportSpecifierDependency.js
@@ -343,7 +343,27 @@ HarmonyImportSpecifierDependency.Template = class HarmonyImportSpecifierDependen
 		}
 
 		if (dep.referencedPropertiesInDestructuring) {
-			const prefixedIds = ids[0] === "default" ? ids.slice(1) : ids;
+			let prefixedIds = ids;
+
+			if (ids[0] === "default") {
+				const selfModule = moduleGraph.getParentModule(dep);
+				const importedModule =
+					/** @type {Module} */
+					(moduleGraph.getModule(dep));
+				const exportsType = importedModule.getExportsType(
+					moduleGraph,
+					/** @type {BuildMeta} */
+					(selfModule.buildMeta).strictHarmonyModule
+				);
+				if (
+					(exportsType === "default-only" ||
+						exportsType === "default-with-named") &&
+					ids.length >= 1
+				) {
+					prefixedIds = ids.slice(1);
+				}
+			}
+
 			for (const {
 				id,
 				shorthand,
diff --git a/test/configCases/mangle/mangle-with-re-export-as-default/index.js b/test/configCases/mangle/mangle-with-re-export-as-default/index.js
@@ -0,0 +1,6 @@
+import namespace from "./re-exports";
+
+it("should mangle exports imported", () => {
+	const { foo } = namespace;
+	expect(foo).toBe('foo')
+});
diff --git a/test/configCases/mangle/mangle-with-re-export-as-default/module.js b/test/configCases/mangle/mangle-with-re-export-as-default/module.js
@@ -0,0 +1 @@
+export const foo = 'foo';
diff --git a/test/configCases/mangle/mangle-with-re-export-as-default/re-exports.js b/test/configCases/mangle/mangle-with-re-export-as-default/re-exports.js
@@ -0,0 +1,3 @@
+import * as namespace from './module';
+
+export { namespace as default };
diff --git a/test/configCases/mangle/mangle-with-re-export-as-default/webpack.config.js b/test/configCases/mangle/mangle-with-re-export-as-default/webpack.config.js
@@ -0,0 +1,9 @@
+/** @type {import("../../../../").Configuration} */
+module.exports = {
+	optimization: {
+		mangleExports: true,
+		usedExports: true,
+		providedExports: true,
+		sideEffects: false // disable reexports optimization
+	}
+};

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+import * as namespace from './module';`
	`2`	`+`
	`3`	`+export { namespace as default };`