Codestin Search App

snitin315 · 2021-05-21T11:57:35Z

For Bugs and Features; did you add new tests?

YES

Motivation / Use-Case

#3300 (comment)

Breaking Changes

No

Additional Info

No

codecov · 2021-05-22T04:00:07Z

Codecov Report

Merging #3325 (2edd362) into master (cef3d85) will decrease coverage by 0.46%.
The diff coverage is 61.11%.

@@            Coverage Diff             @@
##           master    #3325      +/-   ##
==========================================
- Coverage   95.72%   95.25%   -0.47%     
==========================================
  Files          33       34       +1     
  Lines        1309     1327      +18     
  Branches      388      390       +2     
==========================================
+ Hits         1253     1264      +11     
- Misses         52       59       +7     
  Partials        4        4

Impacted Files	Coverage Δ
bin/cli-flags.js	`100.00% <ø> (ø)`
lib/Server.js	`95.01% <61.11%> (-1.27%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84bd080...2edd362. Read the comment docs.

alexander-akait · 2021-05-22T13:56:32Z

@snitin315 I think better finish this before merge it #3309 (here we finish our options)

snitin315 · 2021-05-22T13:59:43Z

It should be good now. Waiting for green CI.

snitin315 · 2021-05-22T14:12:24Z

I have not included -reset flags, I think we need webpack.processArguments for their proper parsing.

alexander-akait · 2021-05-22T14:15:03Z

I think we need webpack.processArguments for their proper parsing.

Ideally - yes, but I think we need -reset flags here, otherwise we will need to do new major release in future, --reset should set array on [], so it should be easy to implement

In theory we can move part of logic webpack.processArguments in own code

snitin315 · 2021-05-22T14:26:56Z

I will update 👍

snitin315 · 2021-05-24T01:34:23Z

Done ✅

alexander-akait

Great job, let's merge it after #3309

snitin315 · 2021-05-26T12:05:54Z

MacOS issue, help output is short in CI.

alexander-akait · 2021-05-26T14:56:43Z

test/cli/cli.test.js

  });

  it('should generate correct cli flags', (done) => {
+    const isMacOS = process.platform === 'darwin';


What is problem? Not all output? It means we have bug somewhere...

I think problem with exec nodejs/node#19218

Yes, good catch 👍

alexander-akait · 2021-05-26T14:59:23Z

test/cli/cli.test.js

+      })
+      .catch(done);
+  });
+


Can we add test: using webpack server --config ./path/webpack.config.js with --watch-files-paths-reset --watch-files-paths ${watchDirectory} and do snapshot (you can set stats: false, we will improve it late), as you can see using expect(output.exitCode).toEqual(0); is bad testing, we need snapshot stdout and stderr, it allow use to see what we rewrite watch-files-paths

We don't log which files are being watched on stderr/stdout

Though we do log for static, added more snapshots 👍🏻

snitin315 · 2021-06-03T12:27:02Z

I will rebase in near future.

alexander-akait · 2021-06-03T12:36:17Z

@snitin315 I will finish it, WIP, also I will add test to ensure we don't lose cli args in future after adding/removing/changes our options

bin/cli-flags.js

snitin315 · 2021-06-08T08:55:12Z

CI is green ✅

snitin315 force-pushed the new-cli branch from e6c3d3e to 4626a43 Compare May 22, 2021 03:50

snitin315 force-pushed the new-cli branch from 4626a43 to 3602226 Compare May 22, 2021 12:02

snitin315 marked this pull request as ready for review May 22, 2021 12:03

snitin315 requested review from alexander-akait, anshumanv, hiroppy and knagaitsev as code owners May 22, 2021 12:03

snitin315 closed this May 22, 2021

snitin315 reopened this May 22, 2021

snitin315 force-pushed the new-cli branch 2 times, most recently from 372f3b1 to 4f42ce2 Compare May 22, 2021 13:52

snitin315 force-pushed the new-cli branch 2 times, most recently from 5b4e85e to d2acaba Compare May 23, 2021 11:41

alexander-akait reviewed May 24, 2021

View reviewed changes

alexander-akait mentioned this pull request May 25, 2021

feat: add webSocketURL option #3309

Merged

6 tasks

snitin315 force-pushed the new-cli branch from d2acaba to 352e88d Compare May 26, 2021 11:53

snitin315 force-pushed the new-cli branch from 352e88d to 5c8c827 Compare May 26, 2021 12:11

alexander-akait reviewed May 26, 2021

View reviewed changes

snitin315 force-pushed the new-cli branch 3 times, most recently from 518685d to 34c46b4 Compare May 28, 2021 09:50

snitin315 force-pushed the new-cli branch from 34c46b4 to 6e60f44 Compare May 29, 2021 03:39

alexander-akait force-pushed the new-cli branch from 67d105f to 8a6c83b Compare June 3, 2021 12:42

This was referenced Jun 3, 2021

feat: new CLI options API for serve webpack/webpack-cli#2754

Merged

fix: migrate server flags to new format #3213

Closed

snitin315 commented Jun 4, 2021

View reviewed changes

bin/cli-flags.js Show resolved Hide resolved

snitin315 and others added 8 commits June 7, 2021 16:10

feat: more cli options

37428e9

test: refactor

f560713

test: refactor

a785ffa

refactor: code

37f02e4

test: update snapshots

8c4e2cd

test: update snapshots

00d83c3

refactor: improve schema

7b88c53

refactor: code

7cbac25

alexander-akait force-pushed the new-cli branch from 89f3e95 to 7cbac25 Compare June 7, 2021 13:11

alexander-akait added 6 commits June 7, 2021 16:14

chore(deps): update

c3c171b

test: update

7501b24

test: update

42f2d91

test: update snapshots

f4a1186

chore: update deps

d35bab0

chore: update deps

2edd362

alexander-akait merged commit 70ed7dc into master Jun 8, 2021

alexander-akait deleted the new-cli branch June 8, 2021 14:10

snitin315 mentioned this pull request Jun 9, 2021

docs: update cli flags #3408

Merged

6 tasks

Uh oh!

Conversation

snitin315 commented May 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

For Bugs and Features; did you add new tests?

Motivation / Use-Case

Breaking Changes

Additional Info

Uh oh!

codecov bot commented May 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

alexander-akait commented May 22, 2021

Uh oh!

snitin315 commented May 22, 2021

Uh oh!

snitin315 commented May 22, 2021

Uh oh!

alexander-akait commented May 22, 2021

Uh oh!

snitin315 commented May 22, 2021

Uh oh!

snitin315 commented May 24, 2021

Uh oh!

alexander-akait left a comment

Choose a reason for hiding this comment

Uh oh!

snitin315 commented May 26, 2021

Uh oh!

alexander-akait May 26, 2021

Choose a reason for hiding this comment

Uh oh!

snitin315 May 26, 2021

Choose a reason for hiding this comment

Uh oh!

alexander-akait May 26, 2021

Choose a reason for hiding this comment

Uh oh!

alexander-akait May 26, 2021

Choose a reason for hiding this comment

Uh oh!

snitin315 May 27, 2021

Choose a reason for hiding this comment

Uh oh!

snitin315 May 29, 2021

Choose a reason for hiding this comment

Uh oh!

snitin315 commented Jun 3, 2021

Uh oh!

alexander-akait commented Jun 3, 2021

Uh oh!

Uh oh!

snitin315 commented Jun 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

snitin315 commented May 21, 2021 •

edited

Loading

codecov bot commented May 22, 2021 •

edited

Loading