From 47030900f29811151b25f77ec4f201255596c96f Mon Sep 17 00:00:00 2001 From: Nitish Dayal Date: Mon, 12 Dec 2016 02:54:03 -0800 Subject: [PATCH 1/9] Update readme.md As requested by Wes Bos. --- readme.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/readme.md b/readme.md index 6c4ee28eea..5a1eaa18c8 100644 --- a/readme.md +++ b/readme.md @@ -6,6 +6,8 @@ Starter Files + Completed solutions for the JavaScript 30 Day Challenge. Grab the course at [https://JavaScript30.com](https://JavaScript30.com) +Text-based guides (unofficial) for the challenges can be found here - [Text Guides](https://github.com/nitishdayal/JavaScript30). + ## Pull Requests These are meant to be 1:1 copies of what is done in the video. If you found a better / different way to do things, great, but I will be keeping them the same as the videos. From 19b44920b14250ca75b05de2c97dc0edee1f7137 Mon Sep 17 00:00:00 2001 From: claudiopro Date: Mon, 12 Dec 2016 19:18:08 +0100 Subject: [PATCH 2/9] =?UTF-8?q?Massages=20Array=20Cardio=20challenges=20?= =?UTF-8?q?=F0=9F=92=AA?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- 04 - Array Cardio Day 1/index-FINISHED.html | 1 + 04 - Array Cardio Day 1/index-START.html | 1 + 07 - Array Cardio Day 2/index-FINISHED.html | 5 +++-- 07 - Array Cardio Day 2/index-START.html | 5 +++-- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/04 - Array Cardio Day 1/index-FINISHED.html b/04 - Array Cardio Day 1/index-FINISHED.html index 377d786a33..e61b94c006 100644 --- a/04 - Array Cardio Day 1/index-FINISHED.html +++ b/04 - Array Cardio Day 1/index-FINISHED.html @@ -5,6 +5,7 @@ Codestin Search App +

Psst: have a look at the JavaScript Console 💁

diff --git a/24 - Sticky Nav/style-START.css b/24 - Sticky Nav/style-START.css index 19961112b4..c6d59a31b3 100644 --- a/24 - Sticky Nav/style-START.css +++ b/24 - Sticky Nav/style-START.css @@ -23,10 +23,6 @@ body { transition: transform 0.5s; } -.fixed-nav .site-wrap { - transform: scale(1); -} - header { text-align: center; height:50vh; @@ -52,11 +48,6 @@ nav { z-index: 1; } -.fixed-nav nav { - position: fixed; - box-shadow: 0 5px rgba(0,0,0,0.1) -} - nav ul { margin: 0; padding:0; @@ -81,10 +72,6 @@ li.logo { font-size: 30px; } -.fixed-nav li.logo { - max-width:500px; -} - li.logo a { color:black; } From acc5d085161a7c1f7ed6c79b754ab61275c671c3 Mon Sep 17 00:00:00 2001 From: the-wazz Date: Wed, 14 Dec 2016 01:30:07 -0500 Subject: [PATCH 5/9] Update index.html spelling. --- 01 - JavaScript Drum Kit/index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/01 - JavaScript Drum Kit/index.html b/01 - JavaScript Drum Kit/index.html index 246639f990..8b4fd26880 100644 --- a/01 - JavaScript Drum Kit/index.html +++ b/01 - JavaScript Drum Kit/index.html @@ -63,7 +63,7 @@ function playSound(e) { const audio = document.querySelector(`audio[data-key="${e.keyCode}"]`); const key = document.querySelector(`.key[data-key="${e.keyCode}"]`); - if (!audio) return; // stop the function from running all together + if (!audio) return; // stop the function from running altogether audio.currentTime = 0; // rewind to the start audio.play(); key.classList.add('playing'); From e0bd3feb16dfd97f9a55965d79217fa052f9eea7 Mon Sep 17 00:00:00 2001 From: Beau Smith Date: Wed, 14 Dec 2016 19:02:58 +0530 Subject: [PATCH 6/9] copy-pasta typo --- 02 - JS + CSS Clock/index-FINISHED.html | 2 +- 02 - JS + CSS Clock/index.html | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/02 - JS + CSS Clock/index-FINISHED.html b/02 - JS + CSS Clock/index-FINISHED.html index d4cb3b56a8..db653a5340 100644 --- a/02 - JS + CSS Clock/index-FINISHED.html +++ b/02 - JS + CSS Clock/index-FINISHED.html @@ -85,7 +85,7 @@ minsHand.style.transform = `rotate(${minsDegrees}deg)`; const hour = now.getHours(); - const hourDegrees = ((mins / 12) * 360) + 90; + const hourDegrees = ((hour / 12) * 360) + 90; hourHand.style.transform = `rotate(${hourDegrees}deg)`; } diff --git a/02 - JS + CSS Clock/index.html b/02 - JS + CSS Clock/index.html index 1c777557da..ae8908f3c9 100644 --- a/02 - JS + CSS Clock/index.html +++ b/02 - JS + CSS Clock/index.html @@ -84,8 +84,8 @@ const minsDegrees = ((mins / 60) * 360) + 90; minsHand.style.transform = `rotate(${minsDegrees}deg)`; - const hour = now.getMinutes(); - const hourDegrees = ((mins / 12) * 360) + 90; + const hour = now.getHours(); + const hourDegrees = ((hour / 12) * 360) + 90; hourHand.style.transform = `rotate(${hourDegrees}deg)`; } From 35c51e299b7f56afc581af81312756512bb9ad69 Mon Sep 17 00:00:00 2001 From: Beau Smith Date: Wed, 14 Dec 2016 20:43:52 +0530 Subject: [PATCH 7/9] Only START and FINISHED files are necessary. --- 02 - JS + CSS Clock/index.html | 96 ---------------------------------- 1 file changed, 96 deletions(-) delete mode 100644 02 - JS + CSS Clock/index.html diff --git a/02 - JS + CSS Clock/index.html b/02 - JS + CSS Clock/index.html deleted file mode 100644 index ae8908f3c9..0000000000 --- a/02 - JS + CSS Clock/index.html +++ /dev/null @@ -1,96 +0,0 @@ - - - - - Codestin Search App - - - - -

- - - - - - - From c45349760093259798cc1d83e3bad1275f8d32c9 Mon Sep 17 00:00:00 2001 From: Tamara Temple Date: Wed, 14 Dec 2016 21:31:47 -0600 Subject: [PATCH 8/9] Remove Exercise 01 index.html file This doesn't seem like it belongs here. The other exercises have the start and finish files, this one seems like it's already been done for us. --- 01 - JavaScript Drum Kit/index.html | 83 ----------------------------- 1 file changed, 83 deletions(-) delete mode 100644 01 - JavaScript Drum Kit/index.html diff --git a/01 - JavaScript Drum Kit/index.html b/01 - JavaScript Drum Kit/index.html deleted file mode 100644 index 8b4fd26880..0000000000 --- a/01 - JavaScript Drum Kit/index.html +++ /dev/null @@ -1,83 +0,0 @@ - - - - - Codestin Search App - - - - - -

- A - clap -

- S - hihat -

- D - kick -

- F - openhat -

- G - boom -

- H - ride -

- J - snare -

- K - tom -

- L - tink -

- -

- - - - - From da100cea606b0ebc29f459f2f862daf4fe9cba19 Mon Sep 17 00:00:00 2001 From: Aristotle Rovithis Date: Fri, 16 Dec 2016 06:21:09 -0500 Subject: [PATCH 9/9] removed answer code from index-START.html Ex 13 --- 13 - Slide in on Scroll/index-START.html | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/13 - Slide in on Scroll/index-START.html b/13 - Slide in on Scroll/index-START.html index 12591bad30..0b9fb8fccb 100644 --- a/13 - Slide in on Scroll/index-START.html +++ b/13 - Slide in on Scroll/index-START.html @@ -58,26 +58,6 @@

Slide in on Scroll

}; } - const sliderImages = document.querySelectorAll('.slide-in'); - - function checkSlide(e) { - sliderImages.forEach(sliderImage => { - // half way through the image - const slideInAt = (window.scrollY + window.innerHeight) - sliderImage.height / 2; - // bottom of the image - const imageBottom = sliderImage.offsetTop + sliderImage.height; - const isHalfShown = slideInAt > sliderImage.offsetTop; - const isNotScrolledPast = window.scrollY < imageBottom; - if (isHalfShown && isNotScrolledPast) { - sliderImage.classList.add('active'); - } else { - sliderImage.classList.remove('active'); - } - }); - } - - window.addEventListener('scroll', debounce(checkSlide)); -