fix: Always output job failure reason in provisioner daemon tests (coder#2850)

kylecarbs · web-flow · commit 4f1df885299c · 2022-07-10T14:52:33.000-05:00
This flake can be seen here: https://github.com/coder/coder/runs/7186604615?check_suite_focus=true
diff --git a/provisionerd/provisionerd_test.go b/provisionerd/provisionerd_test.go
@@ -962,6 +962,14 @@ func createProvisionerd(t *testing.T, dialer provisionerd.Dialer, provisioners p
 // Creates a provisionerd protobuf client that's connected
 // to the server implementation provided.
 func createProvisionerDaemonClient(t *testing.T, server provisionerDaemonTestServer) proto.DRPCProvisionerDaemonClient {
+	if server.failJob == nil {
+		// Default to asserting the error from the failure, otherwise
+		// it can be lost in tests!
+		server.failJob = func(ctx context.Context, job *proto.FailedJob) (*proto.Empty, error) {
+			assert.Fail(t, job.Error)
+			return &proto.Empty{}, nil
+		}
+	}
 	clientPipe, serverPipe := provisionersdk.TransportPipe()
 	t.Cleanup(func() {
 		_ = clientPipe.Close()
