Update marionette keyed to 3.4.2

paulfalgout · paulfalgout · commit ecc7ad3f8ec0 · 2017-08-20T22:02:44.000+09:00
diff --git a/marionette-v3.4.2-keyed/.babelrc b/marionette-v3.4.2-keyed/.babelrc
diff --git a/marionette-v3.4.2-keyed/index.html b/marionette-v3.4.2-keyed/index.html
@@ -2,7 +2,7 @@
 <html lang="en">
 <head>
     <meta charset="utf-8"/>
-    <title>Marionette-v3.4.0</title>
+    <title>Marionette-v3.4.2</title>
     <link href="/css/currentStyle.css" rel="stylesheet"/>
 </head>
 <body>
@@ -11,7 +11,7 @@
         <div class="jumbotron">
             <div class="row">
                 <div class="col-md-6">
-                    <h1>Marionette-v3.4.0</h1>
+                    <h1>Marionette-v3.4.2</h1>
                 </div>
                 <div class="col-md-6">
                     <div class="row">
diff --git a/marionette-v3.4.2-keyed/package.json b/marionette-v3.4.2-keyed/package.json
@@ -1,7 +1,7 @@
 {
   "name": "js-framework-benchmark-marionette",
   "version": "1.0.0",
-  "description": "Marionette v3.4.0",
+  "description": "Marionette v3.4.2",
   "main": "index.js",
   "scripts": {
     "build-dev": "webpack -w -d",
@@ -16,7 +16,7 @@
   },
   "dependencies": {
     "backbone": "1.3.3",
-    "backbone.marionette": "3.4.0",
+    "backbone.marionette": "3.4.2",
     "backbone.radio": "2.0.0",
     "jquery": "3.2.1",
     "underscore": "1.8.3"
diff --git a/marionette-v3.4.2-keyed/src/Main.js b/marionette-v3.4.2-keyed/src/Main.js
@@ -185,10 +185,6 @@ const CollectionView = Mn.NextCollectionView.extend({
         }
         const curSelected = this.children.findByModel(selected);
         curSelected.$el.removeClass('danger');
-    },
-    onBeforeDestroyChildren() {
-        // Handles bugfix coming in v3.4.1
-        this.Dom.detachContents(this.el, this.$el);
     }
 });
 
diff --git a/marionette-v3.4.2-keyed/webpack.config.js b/marionette-v3.4.2-keyed/webpack.config.js
diff --git a/webdriver-ts/src/common.ts b/webdriver-ts/src/common.ts
@@ -57,7 +57,7 @@ export let frameworks = [
     f("ivi-v0.8.0-keyed", true),
     f("knockout-v3.4.1-keyed", true),
     f("marionette-v3.4.0-domapi-keyed", true),
-    f("marionette-v3.4.0-keyed", true),
+    f("marionette-v3.4.2-keyed", true),
     f("marko-v4.3.0-keyed", true),
     f("mithril-v1.1.1-keyed", true),
     f("moon-v0.11.0", false),

Original file line number	Diff line number	Diff line change
`@@ -185,10 +185,6 @@ const CollectionView = Mn.NextCollectionView.extend({`
`185`	`185`	`}`
`186`	`186`	`const curSelected = this.children.findByModel(selected);`
`187`	`187`	`curSelected.$el.removeClass('danger');`
`188`		`- },`
`189`		`- onBeforeDestroyChildren() {`
`190`		`- // Handles bugfix coming in v3.4.1`
`191`		`- this.Dom.detachContents(this.el, this.$el);`
`192`	`188`	`}`
`193`	`189`	`});`
`194`	`190`