Always checkout with case sensitive iterator

Edward Thomson · ethomson · commit d853fb9f24e0 · 2015-01-16T18:56:05.000-05:00
On a case-insensitive filesystem, we need to deal with case-changing
renames (eg, foo -&gt; FOO) by removing the old and adding the new,
exactly as if we were on a case-sensitive filesystem.

Update the `checkout::tree::can_cancel_checkout_from_notify` test, now
that notifications are always sent case sensitively.
diff --git a/src/checkout.c b/src/checkout.c
@@ -2364,7 +2364,7 @@ int git_checkout_tree(
 		}
 	}
 
-	if (!(error = git_iterator_for_tree(&tree_i, tree, 0, NULL, NULL)))
+	if (!(error = git_iterator_for_tree(&tree_i, tree, GIT_ITERATOR_DONT_IGNORE_CASE, NULL, NULL)))
 		error = git_checkout_iterator(tree_i, opts);
 
 	git_iterator_free(tree_i);
diff --git a/tests/checkout/tree.c b/tests/checkout/tree.c
@@ -645,14 +645,7 @@ void test_checkout_tree__can_cancel_checkout_from_notify(void)
 	cl_git_fail_with(git_checkout_tree(g_repo, obj, &opts), -5555);
 
 	cl_assert(!git_path_exists("testrepo/new.txt"));
-
-	/* on case-insensitive FS = a/b.txt, branch_file.txt, new.txt */
-	/* on case-sensitive FS   = README, then above */
-
-	if (git_path_exists("testrepo/.git/CoNfIg")) /* case insensitive */
-		cl_assert_equal_i(3, ca.count);
-	else
-		cl_assert_equal_i(4, ca.count);
+	cl_assert_equal_i(4, ca.count);
 
 	/* and again with a different stopping point and return code */
 	ca.filename = "README";
@@ -662,11 +655,7 @@ void test_checkout_tree__can_cancel_checkout_from_notify(void)
 	cl_git_fail_with(git_checkout_tree(g_repo, obj, &opts), 123);
 
 	cl_assert(!git_path_exists("testrepo/new.txt"));
-
-	if (git_path_exists("testrepo/.git/CoNfIg")) /* case insensitive */
-		cl_assert_equal_i(4, ca.count);
-	else
-		cl_assert_equal_i(1, ca.count);
+	cl_assert_equal_i(1, ca.count);
 
 	git_object_free(obj);
 }

Original file line number	Diff line number	Diff line change
`@@ -2364,7 +2364,7 @@ int git_checkout_tree(`
`2364`	`2364`	`}`
`2365`	`2365`	`}`
`2366`	`2366`
`2367`		`- if (!(error = git_iterator_for_tree(&tree_i, tree, 0, NULL, NULL)))`
	`2367`	`+ if (!(error = git_iterator_for_tree(&tree_i, tree, GIT_ITERATOR_DONT_IGNORE_CASE, NULL, NULL)))`
`2368`	`2368`	`error = git_checkout_iterator(tree_i, opts);`
`2369`	`2369`
`2370`	`2370`	`git_iterator_free(tree_i);`