Add descriptive error messages to logging

frankkusters · frankkusters · commit a3937b1baa3a · 2014-10-28T14:14:48.000+01:00
diff --git a/src/main/java/de/taimos/gpsd4java/backend/GPSdEndpoint.java b/src/main/java/de/taimos/gpsd4java/backend/GPSdEndpoint.java
@@ -113,7 +113,7 @@ public void start() {
 		try {
 			Thread.sleep(500);
 		} catch (final InterruptedException e) {
-			GPSdEndpoint.LOG.debug("", e);
+			GPSdEndpoint.LOG.debug("Interrupted while sleeping", e);
 		}
 	}
 	
@@ -124,7 +124,7 @@ public void stop() {
 		try {
 			this.listenThread.halt();
 		} catch (final Exception e) {
-			GPSdEndpoint.LOG.debug("", e);
+			GPSdEndpoint.LOG.debug("Interrupted while waiting for listenThread to stop", e);
 		}
 		this.listenThread = null;
 	}
@@ -250,7 +250,7 @@ private IGPSObject waitForResult() {
 			try {
 				this.asyncWaitMutex.wait(1000);
 			} catch (final InterruptedException e) {
-				GPSdEndpoint.LOG.info("", e);
+				GPSdEndpoint.LOG.info("Interrupted while waiting for result", e);
 			}
 			if (this.asnycResult != null) {
 				return this.asnycResult;
diff --git a/src/main/java/de/taimos/gpsd4java/backend/SocketThread.java b/src/main/java/de/taimos/gpsd4java/backend/SocketThread.java
@@ -90,7 +90,7 @@ public void run() {
 				break;
 			} catch (final Exception e) {
 				// TODO handle this better
-				SocketThread.LOG.warn("", e);
+				SocketThread.LOG.warn("Problem encountered while reading/parsing/handling line", e);
 			}
 		}
 	}
diff --git a/src/test/java/de/taimos/gpsd4java/test/Tester.java b/src/test/java/de/taimos/gpsd4java/test/Tester.java
@@ -127,7 +127,7 @@ public void handleDevices(final DevicesObject devices) {
 			
 			Thread.sleep(60000);
 		} catch (final Exception e) {
-			Tester.log.error("", e);
+			Tester.log.error("Problem encountered", e);
 		}
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ public void start() {`
`113`	`113`	`try {`
`114`	`114`	`Thread.sleep(500);`
`115`	`115`	`} catch (final InterruptedException e) {`
`116`		`- GPSdEndpoint.LOG.debug("", e);`
	`116`	`+ GPSdEndpoint.LOG.debug("Interrupted while sleeping", e);`
`117`	`117`	`}`
`118`	`118`	`}`
`119`	`119`
`@@ -124,7 +124,7 @@ public void stop() {`
`124`	`124`	`try {`
`125`	`125`	`this.listenThread.halt();`
`126`	`126`	`} catch (final Exception e) {`
`127`		`- GPSdEndpoint.LOG.debug("", e);`
	`127`	`+ GPSdEndpoint.LOG.debug("Interrupted while waiting for listenThread to stop", e);`
`128`	`128`	`}`
`129`	`129`	`this.listenThread = null;`
`130`	`130`	`}`
`@@ -250,7 +250,7 @@ private IGPSObject waitForResult() {`
`250`	`250`	`try {`
`251`	`251`	`this.asyncWaitMutex.wait(1000);`
`252`	`252`	`} catch (final InterruptedException e) {`
`253`		`- GPSdEndpoint.LOG.info("", e);`
	`253`	`+ GPSdEndpoint.LOG.info("Interrupted while waiting for result", e);`
`254`	`254`	`}`
`255`	`255`	`if (this.asnycResult != null) {`
`256`	`256`	`return this.asnycResult;`
Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ public void run() {`
`90`	`90`	`break;`
`91`	`91`	`} catch (final Exception e) {`
`92`	`92`	`// TODO handle this better`
`93`		`- SocketThread.LOG.warn("", e);`
	`93`	`+ SocketThread.LOG.warn("Problem encountered while reading/parsing/handling line", e);`
`94`	`94`	`}`
`95`	`95`	`}`
`96`	`96`	`}`
Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,7 @@ public void handleDevices(final DevicesObject devices) {`
`127`	`127`
`128`	`128`	`Thread.sleep(60000);`
`129`	`129`	`} catch (final Exception e) {`
`130`		`- Tester.log.error("", e);`
	`130`	`+ Tester.log.error("Problem encountered", e);`
`131`	`131`	`}`
`132`	`132`	`}`
`133`	`133`	`}`