-
Notifications
You must be signed in to change notification settings - Fork 315
A small update suggestion in WinPython_Terminal.bat #1262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
And, you could also wrap all %PATH% variables with quotation marks in scripts/env.bat like: echo ";"%PATH%";" | %FINDDIR%\find.exe /C /I ";%WINPYDIR%;" >nul Now my chronic system path problems solved. |
the other one is more complex, so not feeling it |
@stonebig I didn't write all detailes of the second one, but it's about another "spaces in user path" related problem. In my env, both powershell and command prompt returned "cannot find" errors for executables located in windows/system32, such as nvidia-smi.exe which is frequently used for cuda users. I didn't know the cause before I find the solution for WinPython_Terminal.bat. After replacing %PATH% with "%PATH%", problems were solved. like: set PATH="%WINPYDIR%\Lib\site-packages\PyQt5;%WINPYDIR%\Lib\site-packages\PySide2;%WINPYDIR%;%WINPYDIR%\DLLs;%WINPYDIR%\Scripts;%WINPYDIR%..\t;%WINPYDIR%..\t\Julia\bin;%WINPYDIR%..\n;"%PATH%";" |
I had build issues trying the code change, so reverted till further courage. |
Since Windows Terminal can now be configured to be the default console on Windows 10 and Windows 11, I think this feature can be dropped at all. If one install the latest Terminal, he can set his preferences on his own. |
Recently I updated my winpython version to 3.10.11.1 but its Winpython Terminal didn't work.
And I found that's because a space is in my %USERPROFILE% where wt.exe located below so I added quotation marks at the line in scripts/WinPython_Terminal.bat and worked properly.
Maybe you could consider putting quotation marks in advance for upcoming releases.
scripts/WinPython_Terminal.bat line 4:
"%USERPROFILE%\AppData\Local\Microsoft\WindowsApps\wt.exe"
The text was updated successfully, but these errors were encountered: