Fix memory leaks in test_capi (python#98017)

carljm · web-flow · commit be4099e55d30 · 2022-10-07T08:17:41.000-07:00
diff --git a/Lib/test/test_capi.py b/Lib/test/test_capi.py
@@ -1495,6 +1495,9 @@ def unraisable_hook(unraisable):
         unraisable = unraisables[0]
         self.assertIs(unraisable.object, d)
         self.assertEqual(str(unraisable.exc_value), "boom!")
+        # avoid leaking reference cycles
+        del unraisable
+        del unraisables
 
     def test_two_watchers(self):
         d1 = {}
diff --git a/Modules/_testcapimodule.c b/Modules/_testcapimodule.c
@@ -5210,6 +5210,7 @@ dict_watch_callback(PyDict_WatchEvent event,
         Py_DECREF(msg);
         return -1;
     }
+    Py_DECREF(msg);
     return 0;
 }
 
@@ -5224,8 +5225,10 @@ dict_watch_callback_second(PyDict_WatchEvent event,
         return -1;
     }
     if (PyList_Append(g_dict_watch_events, msg) < 0) {
+        Py_DECREF(msg);
         return -1;
     }
+    Py_DECREF(msg);
     return 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -5210,6 +5210,7 @@ dict_watch_callback(PyDict_WatchEvent event,`
`5210`	`5210`	`Py_DECREF(msg);`
`5211`	`5211`	`return -1;`
`5212`	`5212`	`}`
	`5213`	`+ Py_DECREF(msg);`
`5213`	`5214`	`return 0;`
`5214`	`5215`	`}`
`5215`	`5216`
`@@ -5224,8 +5225,10 @@ dict_watch_callback_second(PyDict_WatchEvent event,`
`5224`	`5225`	`return -1;`
`5225`	`5226`	`}`
`5226`	`5227`	`if (PyList_Append(g_dict_watch_events, msg) < 0) {`
	`5228`	`+ Py_DECREF(msg);`
`5227`	`5229`	`return -1;`
`5228`	`5230`	`}`
	`5231`	`+ Py_DECREF(msg);`
`5229`	`5232`	`return 0;`
`5230`	`5233`	`}`
`5231`	`5234`