Tests and added explicit setting of added and deleted lines in patch because linecallback isn't called in this case

Stijn-Rutten · Stijn-Rutten · commit 37fa58584a24 · 2020-05-27T20:48:07.000+02:00
diff --git a/LibGit2Sharp.Tests/DiffTreeToTargetFixture.cs b/LibGit2Sharp.Tests/DiffTreeToTargetFixture.cs
@@ -1,7 +1,7 @@
+using LibGit2Sharp.Tests.TestHelpers;
 using System.IO;
 using System.Linq;
 using System.Text;
-using LibGit2Sharp.Tests.TestHelpers;
 using Xunit;
 
 namespace LibGit2Sharp.Tests
@@ -17,7 +17,7 @@ private static void SetUpSimpleDiffContext(IRepository repo)
 
             File.AppendAllText(fullpath, "world\n");
 
-            Commands.Stage(repo,fullpath);
+            Commands.Stage(repo, fullpath);
 
             File.AppendAllText(fullpath, "!!!\n");
         }
@@ -509,5 +509,25 @@ public void CanCompareANullTreeAgainstTheWorkdirAndTheIndex()
                 }
             }
         }
+
+        [Fact]
+        public void CompareSetsCorrectAddedAndDeletedLines()
+        {
+            string repoPath = InitNewRepository();
+
+            using (var repo = new Repository(repoPath))
+            {
+                SetUpSimpleDiffContext(repo);
+
+                using (var changes = repo.Diff.Compare<Patch>(repo.Head.Tip.Tree,
+                    DiffTargets.WorkingDirectory | DiffTargets.Index))
+                {
+                    foreach (var entry in changes)
+                    {
+                        Assert.Equal(2, entry.AddedLines.Count());
+                    }
+                }
+            }
+        }
     }
 }
diff --git a/LibGit2Sharp.Tests/DiffTreeToTreeFixture.cs b/LibGit2Sharp.Tests/DiffTreeToTreeFixture.cs
@@ -1,10 +1,9 @@
-﻿using System;
+﻿using LibGit2Sharp.Tests.TestHelpers;
+using System;
 using System.IO;
 using System.Linq;
 using System.Text;
-using LibGit2Sharp.Tests.TestHelpers;
 using Xunit;
-using Xunit.Extensions;
 
 namespace LibGit2Sharp.Tests
 {
@@ -20,7 +19,7 @@ public void ComparingATreeAgainstItselfReturnsNoDifference()
             {
                 Tree tree = repo.Head.Tip.Tree;
 
-                using(var changes = repo.Diff.Compare<TreeChanges>(tree, tree))
+                using (var changes = repo.Diff.Compare<TreeChanges>(tree, tree))
                 {
                     Assert.Empty(changes);
                 }
@@ -112,13 +111,13 @@ public void CanDetectABinaryChange()
 
                 File.AppendAllText(filepath, "abcdef");
 
-                using(var patch = repo.Diff.Compare<Patch>(commit.Tree, DiffTargets.WorkingDirectory, new[] { filename }))
+                using (var patch = repo.Diff.Compare<Patch>(commit.Tree, DiffTargets.WorkingDirectory, new[] { filename }))
                     Assert.True(patch[filename].IsBinaryComparison);
 
                 Commands.Stage(repo, filename);
                 var commit2 = repo.Commit("Update binary file", Constants.Signature, Constants.Signature);
 
-                using(var patch2 = repo.Diff.Compare<Patch>(commit.Tree, commit2.Tree, new[] { filename }))
+                using (var patch2 = repo.Diff.Compare<Patch>(commit.Tree, commit2.Tree, new[] { filename }))
                     Assert.True(patch2[filename].IsBinaryComparison);
             }
         }
@@ -138,13 +137,13 @@ public void CanDetectABinaryDeletion()
 
                 File.Delete(filepath);
 
-                using(var patch = repo.Diff.Compare<Patch>(commit.Tree, DiffTargets.WorkingDirectory, new [] {filename}))
+                using (var patch = repo.Diff.Compare<Patch>(commit.Tree, DiffTargets.WorkingDirectory, new[] { filename }))
                     Assert.True(patch[filename].IsBinaryComparison);
 
                 Commands.Remove(repo, filename);
                 var commit2 = repo.Commit("Delete binary file", Constants.Signature, Constants.Signature);
 
-                using(var patch2 = repo.Diff.Compare<Patch>(commit.Tree, commit2.Tree, new[] { filename }))
+                using (var patch2 = repo.Diff.Compare<Patch>(commit.Tree, commit2.Tree, new[] { filename }))
                     Assert.True(patch2[filename].IsBinaryComparison);
             }
         }
@@ -704,7 +703,7 @@ public void CanIncludeUnmodifiedEntriesWhenEnabled()
                 Touch(repo.Info.WorkingDirectory, "a.txt", "abc\ndef\n");
                 Touch(repo.Info.WorkingDirectory, "b.txt", "abc\ndef\n");
 
-                Commands.Stage(repo, new[] {"a.txt", "b.txt"});
+                Commands.Stage(repo, new[] { "a.txt", "b.txt" });
                 Commit old = repo.Commit("Initial", Constants.Signature, Constants.Signature);
 
                 File.AppendAllText(Path.Combine(repo.Info.WorkingDirectory, "b.txt"), "ghi\njkl\n");
@@ -728,12 +727,12 @@ public void CanDetectTheExactRenamingExactCopyingOfNonModifiedAndModifiedFilesWh
             var path = Repository.Init(scd.DirectoryPath);
             using (var repo = new Repository(path))
             {
-                const string originalPath =  "original.txt";
-                const string renamedPath =   "renamed.txt";
+                const string originalPath = "original.txt";
+                const string renamedPath = "renamed.txt";
                 const string originalPath2 = "original2.txt";
-                const string copiedPath1 =   "copied.txt";
+                const string copiedPath1 = "copied.txt";
                 const string originalPath3 = "original3.txt";
-                const string copiedPath2 =   "copied2.txt";
+                const string copiedPath2 = "copied2.txt";
 
                 Touch(repo.Info.WorkingDirectory, originalPath, "a\nb\nc\nd\n");
                 Touch(repo.Info.WorkingDirectory, originalPath2, "1\n2\n3\n4\n");
@@ -986,7 +985,7 @@ public void CanHandleTwoTreeEntryChangesWithTheSamePathUsingSimilarityNone()
                     Assert.Single(changes.Deleted);
                     Assert.Single(changes.TypeChanged);
 
-                    TreeEntryChanges change = changes.Single(c => c.Path== path);
+                    TreeEntryChanges change = changes.Single(c => c.Path == path);
                     Assert.Equal(Mode.SymbolicLink, change.OldMode);
                     Assert.Equal(Mode.NonExecutableFile, change.Mode);
                     Assert.Equal(ChangeKind.TypeChanged, change.Status);
@@ -1087,7 +1086,7 @@ public void ComparingReliesOnProvidedConfigEntriesIfAny()
             using (var repo = new Repository(path))
             {
                 SetFilemode(repo, true);
-                using(var changes = repo.Diff.Compare<TreeChanges>(new[] { file }))
+                using (var changes = repo.Diff.Compare<TreeChanges>(new[] { file }))
                 {
                     Assert.Single(changes);
 
@@ -1147,6 +1146,44 @@ public void RetrievingDiffChangesMustAlwaysBeCaseSensitive()
             }
         }
 
+        [Fact]
+        public void RetrievingDiffContainsRightAmountOfAddedAndDeletedLines()
+        {
+            ObjectId treeOldOid, treeNewOid;
+
+            string repoPath = InitNewRepository();
+
+            using (var repo = new Repository(repoPath))
+            {
+                Blob oldContent = OdbHelper.CreateBlob(repo, "awesome content\n");
+                Blob newContent = OdbHelper.CreateBlob(repo, "more awesome content\n");
+
+                var td = new TreeDefinition()
+                    .Add("A.TXT", oldContent, Mode.NonExecutableFile)
+                    .Add("a.txt", oldContent, Mode.NonExecutableFile);
+
+                treeOldOid = repo.ObjectDatabase.CreateTree(td).Id;
+
+                td = new TreeDefinition()
+                    .Add("A.TXT", newContent, Mode.NonExecutableFile)
+                    .Add("a.txt", newContent, Mode.NonExecutableFile);
+
+                treeNewOid = repo.ObjectDatabase.CreateTree(td).Id;
+            }
+
+            using (var repo = new Repository(repoPath))
+            {
+                using (var changes = repo.Diff.Compare<Patch>(repo.Lookup<Tree>(treeOldOid), repo.Lookup<Tree>(treeNewOid)))
+                {
+                    foreach (var entry in changes)
+                    {
+                        Assert.Single(entry.AddedLines);
+                        Assert.Single(entry.DeletedLines);
+                    }
+                }
+            }
+        }
+
         [Fact]
         public void UsingPatienceAlgorithmCompareOptionProducesPatienceDiff()
         {
diff --git a/LibGit2Sharp/Patch.cs b/LibGit2Sharp/Patch.cs
@@ -1,11 +1,11 @@
+using LibGit2Sharp.Core;
+using LibGit2Sharp.Core.Handles;
 using System;
 using System.Collections;
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Globalization;
 using System.Text;
-using LibGit2Sharp.Core;
-using LibGit2Sharp.Core.Handles;
 
 namespace LibGit2Sharp
 {
@@ -70,8 +70,8 @@ private unsafe int PrintCallBack(git_diff_delta* delta, GitDiffHunk hunk, GitDif
 
             string decodedContent = LaxUtf8Marshaler.FromNative(line.content, (int)line.contentLen);
 
-            currentChange.AddedLines = new List<Line>();
-            currentChange.DeletedLines = new List<Line>();
+            currentChange.AddedLines = currentChange.AddedLines ?? new List<Line>();
+            currentChange.DeletedLines = currentChange.DeletedLines ?? new List<Line>();
 
             switch (line.lineOrigin)
             {
@@ -175,7 +175,7 @@ public virtual string Content
         /// </summary>
         /// <param name="patch"><see cref="Patch"/>.</param>
         /// <returns>The patch content as string.</returns>
-        public static implicit operator string (Patch patch)
+        public static implicit operator string(Patch patch)
         {
             return patch.fullPatchBuilder.ToString();
         }
