minor EasyCorp#995 Improved tests for the "search" view (javiereguiluz)

javiereguiluz · javiereguiluz · commit 563f0de422e9 · 2016-03-14T20:45:59.000+01:00
This PR was merged into the master branch. Discussion ---------- Improved tests for the "search" view We've fixed the same problem three times: here (https://github.com/javiereguiluz/EasyAdminBundle/pull/894), here (https://github.com/javiereguiluz/EasyAdminBundle/pull/863) and here (https://github.com/javiereguiluz/EasyAdminBundle/pull/994). Let's improve the test to forget about this issue forever. Commits ------- a4a36ea Improved tests for the "search" view
diff --git a/Tests/Controller/DefaultBackendTest.php b/Tests/Controller/DefaultBackendTest.php
@@ -490,8 +490,8 @@ public function testSearchViewTitle()
     {
         $crawler = $this->requestSearchView();
 
-        $this->assertEquals('200 results found', trim($crawler->filter('head title')->text()));
-        $this->assertEquals('200 results found', trim($crawler->filter('h1.title')->text()));
+        $this->assertEquals('200 results found', trim($crawler->filter('head title')->html()), 'The page title does not contain HTML tags.');
+        $this->assertEquals('<strong>200</strong> results found', trim($crawler->filter('h1.title')->html()), 'The visible content contains HTML tags.');
     }
 
     public function testSearchViewTableIdColumn()

Original file line number	Diff line number	Diff line change
`@@ -490,8 +490,8 @@ public function testSearchViewTitle()`
`490`	`490`	`{`
`491`	`491`	`$crawler = $this->requestSearchView();`
`492`	`492`
`493`		`- $this->assertEquals('200 results found', trim($crawler->filter('head title')->text()));`
`494`		`- $this->assertEquals('200 results found', trim($crawler->filter('h1.title')->text()));`
	`493`	`+ $this->assertEquals('200 results found', trim($crawler->filter('head title')->html()), 'The page title does not contain HTML tags.');`
	`494`	`+ $this->assertEquals('<strong>200</strong> results found', trim($crawler->filter('h1.title')->html()), 'The visible content contains HTML tags.');`
`495`	`495`	`}`
`496`	`496`
`497`	`497`	`public function testSearchViewTableIdColumn()`