From bc9f44063f88f0959eec09997ec828ce9ad7debc Mon Sep 17 00:00:00 2001 From: Anderson Banihirwe Date: Fri, 16 Jun 2023 12:11:39 -0600 Subject: [PATCH 1/3] use GH deployment environment for pull request previews --- .github/workflows/preview.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.github/workflows/preview.yaml b/.github/workflows/preview.yaml index 0b96db81..466afd21 100644 --- a/.github/workflows/preview.yaml +++ b/.github/workflows/preview.yaml @@ -5,9 +5,21 @@ on: [pull_request] permissions: pull-requests: write # allow surge-preview to create/update PR comments +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + +env: + PREVIEW_URL: 'https://github.com/{{ github.repository }}-{{ github.job }}-pr-{{ github.event.number }}.surge.sh' + PRODUCTION_URL: 'https://tutorial.xarray.dev/' + jobs: preview: runs-on: ubuntu-latest + environment: + name: ${{ github.ref == 'refs/heads/main' && 'production' || 'preview' }} + url: ${{ github.ref == 'refs/heads/main' && env.PRODUCTION_URL || env.PREVIEW_URL }} + steps: - name: Checkout repository uses: actions/checkout@v3 From 7cdaadc8f18c2340fddef57680e62ed1fb100232 Mon Sep 17 00:00:00 2001 From: Anderson Banihirwe Date: Fri, 16 Jun 2023 12:16:49 -0600 Subject: [PATCH 2/3] fix preview URL --- .github/workflows/preview.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/preview.yaml b/.github/workflows/preview.yaml index 466afd21..a5f2825c 100644 --- a/.github/workflows/preview.yaml +++ b/.github/workflows/preview.yaml @@ -10,7 +10,7 @@ concurrency: cancel-in-progress: true env: - PREVIEW_URL: 'https://github.com/{{ github.repository }}-{{ github.job }}-pr-{{ github.event.number }}.surge.sh' + PREVIEW_URL: 'https://{{ github.repository_owner }}-{{ github.event.repository.name }}-{{ github.job }}-pr-{{ github.event.number }}.surge.sh' PRODUCTION_URL: 'https://tutorial.xarray.dev/' jobs: From 5285d6581efbc71630e19880ccbe8ba9d1ceb2b6 Mon Sep 17 00:00:00 2001 From: Anderson Banihirwe Date: Fri, 16 Jun 2023 12:27:22 -0600 Subject: [PATCH 3/3] try again --- .github/workflows/preview.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/preview.yaml b/.github/workflows/preview.yaml index a5f2825c..33ecc584 100644 --- a/.github/workflows/preview.yaml +++ b/.github/workflows/preview.yaml @@ -10,15 +10,15 @@ concurrency: cancel-in-progress: true env: - PREVIEW_URL: 'https://{{ github.repository_owner }}-{{ github.event.repository.name }}-{{ github.job }}-pr-{{ github.event.number }}.surge.sh' - PRODUCTION_URL: 'https://tutorial.xarray.dev/' + PREVIEW_URL: 'https://{{ github.repository_owner }}-{{ github.event.repository.name }}-preview-pr-{{ github.event.number }}.surge.sh' jobs: preview: + if: github.ref != 'refs/heads/main' runs-on: ubuntu-latest environment: - name: ${{ github.ref == 'refs/heads/main' && 'production' || 'preview' }} - url: ${{ github.ref == 'refs/heads/main' && env.PRODUCTION_URL || env.PREVIEW_URL }} + name: 'preview' + url: ${{ env.PREVIEW_URL }} steps: - name: Checkout repository