fix(eslint-plugin): [consistent-type-assertions] handle tagged templates (typescript-eslint#8993)

yeonjuan · web-flow · commit 51d21931e31b · 2024-04-26T07:24:05.000-04:00
diff --git a/packages/eslint-plugin/src/rules/consistent-type-assertions.ts b/packages/eslint-plugin/src/rules/consistent-type-assertions.ts
@@ -223,7 +223,10 @@ export default createRule<Options, MessageIds>({
           node.parent.type === AST_NODE_TYPES.CallExpression ||
           node.parent.type === AST_NODE_TYPES.ThrowStatement ||
           node.parent.type === AST_NODE_TYPES.AssignmentPattern ||
-          node.parent.type === AST_NODE_TYPES.JSXExpressionContainer)
+          node.parent.type === AST_NODE_TYPES.JSXExpressionContainer ||
+          (node.parent.type === AST_NODE_TYPES.TemplateLiteral &&
+            node.parent.parent.type ===
+              AST_NODE_TYPES.TaggedTemplateExpression))
       ) {
         return;
       }
diff --git a/packages/eslint-plugin/tests/rules/consistent-type-assertions.test.ts b/packages/eslint-plugin/tests/rules/consistent-type-assertions.test.ts
@@ -26,7 +26,8 @@ const x = new (<Foo>Generic<string>)();
 const x = new (<Foo>Generic<string>)('string');
 const x = () => <Foo>{ bar: 5 };
 const x = () => <Foo>({ bar: 5 });
-const x = () => <Foo>bar;`;
+const x = () => <Foo>bar;
+const x = <Foo>bar<string>\`\${"baz"}\`;`;
 
 const ANGLE_BRACKET_TESTS = `${ANGLE_BRACKET_TESTS_EXCEPT_CONST_CASE}
 const x = <const>{ key: 'value' };
@@ -45,7 +46,8 @@ const x = new (Generic<string> as Foo)();
 const x = new (Generic<string> as Foo)('string');
 const x = () => ({ bar: 5 } as Foo);
 const x = () => ({ bar: 5 } as Foo);
-const x = () => (bar as Foo);`;
+const x = () => (bar as Foo);
+const x = bar<string>\`\${"baz"}\` as Foo;`;
 
 const AS_TESTS = `${AS_TESTS_EXCEPT_CONST_CASE}
 const x = { key: 'value' } as const;
@@ -69,13 +71,15 @@ function b(x = {} as Foo.Bar) {}
 function c(x = {} as Foo) {}
 print?.({ bar: 5 } as Foo)
 print?.call({ bar: 5 } as Foo)
+print\`\${{ bar: 5 } as Foo}\`
 `;
 const OBJECT_LITERAL_ARGUMENT_ANGLE_BRACKET_CASTS = `
 print(<Foo>{ bar: 5 })
 new print(<Foo>{ bar: 5 })
 function foo() { throw <Foo>{ bar: 5 } }
 print?.(<Foo>{ bar: 5 })
 print?.call(<Foo>{ bar: 5 })
+print\`\${<Foo>{ bar: 5 }}\`
 `;
 
 ruleTester.run('consistent-type-assertions', rule, {
@@ -230,6 +234,10 @@ ruleTester.run('consistent-type-assertions', rule, {
           messageId: 'angle-bracket',
           line: 15,
         },
+        {
+          messageId: 'angle-bracket',
+          line: 16,
+        },
       ],
     }),
     ...batchedSingleLineTests<MessageIds, Options>({
@@ -296,6 +304,10 @@ ruleTester.run('consistent-type-assertions', rule, {
           messageId: 'as',
           line: 15,
         },
+        {
+          messageId: 'as',
+          line: 16,
+        },
       ],
       output: AS_TESTS,
     }),
@@ -359,6 +371,10 @@ ruleTester.run('consistent-type-assertions', rule, {
           messageId: 'never',
           line: 14,
         },
+        {
+          messageId: 'never',
+          line: 15,
+        },
       ],
     }),
     ...batchedSingleLineTests<MessageIds, Options>({
@@ -421,6 +437,10 @@ ruleTester.run('consistent-type-assertions', rule, {
           messageId: 'never',
           line: 14,
         },
+        {
+          messageId: 'never',
+          line: 15,
+        },
       ],
     }),
     ...batchedSingleLineTests<MessageIds, Options>({
@@ -660,6 +680,17 @@ ruleTester.run('consistent-type-assertions', rule, {
             },
           ],
         },
+        {
+          messageId: 'unexpectedObjectTypeAssertion',
+          line: 12,
+          suggestions: [
+            {
+              messageId: 'replaceObjectTypeAssertionWithSatisfies',
+              data: { cast: 'Foo' },
+              output: `print\`\${{ bar: 5 } satisfies Foo}\``,
+            },
+          ],
+        },
       ],
     }),
     ...batchedSingleLineTests<MessageIds, Options>({
@@ -769,6 +800,17 @@ ruleTester.run('consistent-type-assertions', rule, {
             },
           ],
         },
+        {
+          messageId: 'unexpectedObjectTypeAssertion',
+          line: 10,
+          suggestions: [
+            {
+              messageId: 'replaceObjectTypeAssertionWithSatisfies',
+              data: { cast: 'Foo' },
+              output: `print\`\${{ bar: 5 } satisfies Foo}\``,
+            },
+          ],
+        },
       ],
     }),
     {
