fix minor issues

Davide Faconti · Davide Faconti · commit b23491fec4f0 · 2020-05-30T15:26:27.000+02:00
diff --git a/include/behaviortree_cpp_v3/bt_parser.h b/include/behaviortree_cpp_v3/bt_parser.h
@@ -16,7 +16,7 @@ class Parser
   public:
     Parser() = default;
 
-    ~Parser() = default;
+    virtual ~Parser() = default;
 
     Parser(const Parser& other) = delete;
     Parser& operator=(const Parser& other) = delete;
diff --git a/include/behaviortree_cpp_v3/utils/simple_string.hpp b/include/behaviortree_cpp_v3/utils/simple_string.hpp
@@ -31,6 +31,13 @@ class SimpleString
     {
     }
 
+    SimpleString& operator = (const SimpleString& other)
+    {
+      _data = other._data;
+      _size = other._size;
+      return *this;
+    }
+
     ~SimpleString()
     {
         if ( _size >= sizeof(void*) && _data.ptr )
diff --git a/sample_nodes/crossdoor_nodes.h b/sample_nodes/crossdoor_nodes.h
@@ -1,3 +1,5 @@
+#pragma once
+
 #include "behaviortree_cpp_v3/bt_factory.h"
 
 using namespace BT;
diff --git a/src/basic_types.cpp b/src/basic_types.cpp
@@ -101,12 +101,6 @@ std::string convertFromString<std::string>(StringView str)
 }
 
 
-template <>
-const char* convertFromString<const char*>(StringView str)
-{
-    return static_cast<std::string>(str).c_str();
-}
-
 template <>
 int convertFromString<int>(StringView str)
 {

Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,13 @@ class SimpleString`
`31`	`31`	`{`
`32`	`32`	`}`
`33`	`33`
	`34`	`+ SimpleString& operator = (const SimpleString& other)`
	`35`	`+ {`
	`36`	`+ _data = other._data;`
	`37`	`+ _size = other._size;`
	`38`	`+ return *this;`
	`39`	`+ }`
	`40`	`+`
`34`	`41`	`~SimpleString()`
`35`	`42`	`{`
`36`	`43`	`if ( _size >= sizeof(void*) && _data.ptr )`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+#pragma once`
	`2`	`+`
`1`	`3`	`#include "behaviortree_cpp_v3/bt_factory.h"`
`2`	`4`
`3`	`5`	`using namespace BT;`
Original file line number	Diff line number	Diff line change
`@@ -101,12 +101,6 @@ std::string convertFromString<std::string>(StringView str)`
`101`	`101`	`}`
`102`	`102`
`103`	`103`
`104`		`-template <>`
`105`		`-const char* convertFromString<const char*>(StringView str)`
`106`		`-{`
`107`		`- return static_cast<std::string>(str).c_str();`
`108`		`-}`
`109`		`-`
`110`	`104`	`template <>`
`111`	`105`	`int convertFromString<int>(StringView str)`
`112`	`106`	`{`