Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 86cf33c

Browse files
committed
add info about 'making pull requests'
1 parent d7a62b1 commit 86cf33c

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

CONTRIBUTING.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,20 @@ community.plot.ly (tagged [`plotly-js`](http://community.plot.ly/c/plotly-js)) o
1717
Comments on GitHub issues or pull requests should add content to the discussions.
1818
Approbation comments such as *+1* or *I would like this feature to be implemented as well* will be deleted by the maintainers. Please use [GitHub reactions](https://github.com/blog/2119-add-reactions-to-pull-requests-issues-and-comments) instead.
1919

20+
## Making pull requests
21+
22+
Developers are strongly encouraged to first make a PR to their own plotly.js
23+
fork and ask one of the maintainers to review the modifications there. Once the
24+
pull request is deemed satisfactory, the developer will be asked to make a pull
25+
request to the main plotly.js repo and may be asked to squash some commits
26+
before doing so.
27+
28+
It is forbidden to force push (i.e. `git push -f`) to remote branches
29+
associated with opened pull requests. Force pushes make it hard for maintainers
30+
to keep track of updates. Therefore, if required, please `git merge
31+
master` into your PR branch instead of `git rebase master`.
32+
33+
2034
## Issue labels
2135

2236
We use the following [labels](https://github.com/plotly/plotly.js/labels) to track issues:

0 commit comments

Comments
 (0)