[codex] Fix RDMA request lifetime during flush#6217
Draft
EvgeniyKozev wants to merge 1 commit into
Draft
Conversation
Contributor
|
Note This is an automated comment that will be appended during run. Note All workloads for linux-x86_64-relwithdebinfo have completed. Tip Planned checks for linux-x86_64-relwithdebinfo. 🟢 linux-x86_64-relwithdebinfo target: cloud/tasks/,cloud/storage/ (test time: 256s): all tests PASSED for commit 43a197b.
🟢 linux-x86_64-relwithdebinfo target: cloud/disk_manager/ (test time: 237s): all tests PASSED for commit 43a197b.
🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 1365s): all tests PASSED for commit 43a197b.
🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 5022s): all tests PASSED for commit 43a197b.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an RDMA server lifetime bug where a session could be considered flushed after WR queues drained while an application handler still owned the raw request context and RDMA pool-backed output buffer.
The session now tracks requests handed to
IServerHandlerand keeps the session alive until the request returns throughSendResponse/SendError. This prevents async callbacks from serializing into freed RDMA pool memory after disconnect/flush.Also pins RDMA server endpoints across async blockstore endpoint callbacks and fixes the local read SGList lifetime/path covered by the current tests.
Validation
git --no-pager diff --check./ya make -tt cloud/storage/core/libs/rdma/impl/ut./ya make -tt cloud/blockstore/libs/client_rdma/ut./ya make cloud/blockstore/libs/service_rdma cloud/blockstore/libs/endpoints_rdma cloud/blockstore/libs/storage/disk_agent./ya make -tt cloud/blockstore/libs/storage/disk_agent/ut