fix(eslint-plugin): [no-unsafe-assignment] handle shorthand property assignment (typescript-eslint#8800)

yeonjuan · web-flow · commit d07eb9e08039 · 2024-04-19T09:50:26.000-06:00
* fix(eslint-plugin): [no-unsafe-assignment] handle shorthand property assignment

* fix formatting
diff --git a/packages/eslint-plugin/tests/rules/no-unsafe-assignment.test.ts b/packages/eslint-plugin/tests/rules/no-unsafe-assignment.test.ts
@@ -157,6 +157,11 @@ declare function Foo(props: { a: string }): never;
     'const x: Set<unknown> = y as Set<any>;',
     // https://github.com/typescript-eslint/typescript-eslint/issues/2109
     'const x: Map<string, string> = new Map();',
+    `
+type Foo = { bar: unknown };
+const bar: any = 1;
+const foo: Foo = { bar };
+    `,
   ],
   invalid: [
     {
@@ -389,5 +394,20 @@ const test: T = ['string', []] as any;
         },
       ],
     },
+    {
+      code: `
+type Foo = { bar: number };
+const bar: any = 1;
+const foo: Foo = { bar };
+      `,
+      errors: [
+        {
+          messageId: 'anyAssignment',
+          line: 4,
+          column: 20,
+          endColumn: 23,
+        },
+      ],
+    },
   ],
 });
diff --git a/packages/type-utils/src/getContextualType.ts b/packages/type-utils/src/getContextualType.ts
@@ -24,7 +24,11 @@ export function getContextualType(
     return parent.type ? checker.getTypeFromTypeNode(parent.type) : undefined;
   } else if (ts.isJsxExpression(parent)) {
     return checker.getContextualType(parent);
-  } else if (ts.isPropertyAssignment(parent) && ts.isIdentifier(node)) {
+  } else if (
+    ts.isIdentifier(node) &&
+    (ts.isPropertyAssignment(parent) ||
+      ts.isShorthandPropertyAssignment(parent))
+  ) {
     return checker.getContextualType(node);
   } else if (
     ts.isBinaryExpression(parent) &&
