minW yarn test fixes

adumesny · adumesny · commit 6231831f1e44 · 2025-02-27T09:18:14.000-08:00
* fixed gridstack#2964 yarn test breaking (good thing for unit tests!)
diff --git a/spec/gridstack-spec.ts b/spec/gridstack-spec.ts
@@ -1252,9 +1252,9 @@ describe('gridstack >', function() {
       grid.update(el, {maxW: 2});
       expect(parseInt(el.getAttribute('gs-x'), 10)).toBe(4);
       expect(parseInt(el.getAttribute('gs-y'), 10)).toBe(0);
+      expect(parseInt(el.getAttribute('gs-w'), 10)).toBe(2);
       expect(parseInt(el.getAttribute('gs-h'), 10)).toBe(4);
       expect(el.gridstackNode.maxW).toBe(2);
-      expect(parseInt(el.getAttribute('gs-w'), 10)).toBe(2);
     });
     it('should change all max and move, no inf loop! >', function() {
       grid = GridStack.init({float: true});
diff --git a/src/gridstack.ts b/src/gridstack.ts
@@ -510,7 +510,7 @@ export class GridStack {
 
     return el;
   }
-  
+
   /**
    * Convert an existing gridItem element into a sub-grid with the given (optional) options, else inherit them
    * from the parent's subGrid options.
@@ -1312,20 +1312,10 @@ export class GridStack {
    */
   public update(els: GridStackElement, opt: GridStackWidget): GridStack {
 
-    // support legacy call for now ?
-    if (arguments.length > 2) {
-      console.warn('gridstack.ts: `update(el, x, y, w, h)` is deprecated. Use `update(el, {x, w, content, ...})`. It will be removed soon');
-      // eslint-disable-next-line prefer-rest-params
-      const a = arguments;
-      let i = 1;
-      opt = { x: a[i++], y: a[i++], w: a[i++], h: a[i++] };
-      return this.update(els, opt);
-    }
-
     GridStack.getElements(els).forEach(el => {
       const n = el?.gridstackNode;
       if (!n) return;
-      const w = Utils.cloneDeep(opt); // make a copy we can modify in case they re-use it or multiple items
+      const w = {...Utils.copyPos({}, n), ...Utils.cloneDeep(opt)}; // make a copy we can modify in case they re-use it or multiple items
       this.engine.nodeBoundFix(w);
       delete w.autoPosition;
 
