Fix bug in native pipe, where we loose End() output

Sergei Vorobev · Sergei Vorobev · commit 7914c75504e5 · 2016-11-15T14:49:39.000-08:00
diff --git a/src/System.Management.Automation/engine/NativeCommandProcessor.cs b/src/System.Management.Automation/engine/NativeCommandProcessor.cs
@@ -1718,7 +1718,11 @@ internal void Add(object input)
 
         private void AddTextInput(object input)
         {
-            Array formattedObjects = _pipeline.Process(input);
+            AddTextInputFromFormattedArray(_pipeline.Process(input));
+        }
+
+        private void AddTextInputFromFormattedArray(Array formattedObjects)
+        {
             foreach (var item in formattedObjects)
             {
                 string line = PSObject.ToStringParser(_command.Context, item);
@@ -1821,7 +1825,7 @@ internal void Done()
             // the calls are on the same thread, so there is no race condition.
             if (_pipeline != null)
             {
-                _pipeline.End();
+                AddTextInputFromFormattedArray(_pipeline.End());
                 _pipeline.Dispose();
                 _pipeline = null;
             }

Original file line number	Diff line number	Diff line change
`@@ -1718,7 +1718,11 @@ internal void Add(object input)`
`1718`	`1718`
`1719`	`1719`	`private void AddTextInput(object input)`
`1720`	`1720`	`{`
`1721`		`- Array formattedObjects = _pipeline.Process(input);`
	`1721`	`+ AddTextInputFromFormattedArray(_pipeline.Process(input));`
	`1722`	`+ }`
	`1723`	`+`
	`1724`	`+ private void AddTextInputFromFormattedArray(Array formattedObjects)`
	`1725`	`+ {`
`1722`	`1726`	`foreach (var item in formattedObjects)`
`1723`	`1727`	`{`
`1724`	`1728`	`string line = PSObject.ToStringParser(_command.Context, item);`
`@@ -1821,7 +1825,7 @@ internal void Done()`
`1821`	`1825`	`// the calls are on the same thread, so there is no race condition.`
`1822`	`1826`	`if (_pipeline != null)`
`1823`	`1827`	`{`
`1824`		`- _pipeline.End();`
	`1828`	`+ AddTextInputFromFormattedArray(_pipeline.End());`
`1825`	`1829`	`_pipeline.Dispose();`
`1826`	`1830`	`_pipeline = null;`
`1827`	`1831`	`}`