zendframework/zendframework#6730 zendframework/zendframework#6761 - clarifying on weird warning assertions

Ocramius · Ocramius · commit 138488a86354 · 2014-12-31T10:30:45.000+01:00
diff --git a/test/Reader/XmlTest.php b/test/Reader/XmlTest.php
@@ -152,6 +152,8 @@ public function testCloseWhenCallFromFileReaderGetInvalid()
         $xmlReader = $this->getInternalXmlReader($configReader);
 
         $this->setExpectedException('PHPUnit_Framework_Error_Warning');
+
+        // following operation should fail because the internal reader is closed (and expected to be closed)
         $xmlReader->setParserProperty(XMLReader::VALIDATE, true);
     }
 
@@ -178,6 +180,8 @@ public function testCloseWhenCallFromStringReaderGetInvalid()
         $xmlReader = $this->getInternalXmlReader($configReader);
 
         $this->setExpectedException('PHPUnit_Framework_Error_Warning');
+
+        // following operation should fail because the internal reader is closed (and expected to be closed)
         $xmlReader->setParserProperty(XMLReader::VALIDATE, true);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -152,6 +152,8 @@ public function testCloseWhenCallFromFileReaderGetInvalid()`
`152`	`152`	`$xmlReader = $this->getInternalXmlReader($configReader);`
`153`	`153`
`154`	`154`	`$this->setExpectedException('PHPUnit_Framework_Error_Warning');`
	`155`	`+`
	`156`	`+ // following operation should fail because the internal reader is closed (and expected to be closed)`
`155`	`157`	`$xmlReader->setParserProperty(XMLReader::VALIDATE, true);`
`156`	`158`	`}`
`157`	`159`
`@@ -178,6 +180,8 @@ public function testCloseWhenCallFromStringReaderGetInvalid()`
`178`	`180`	`$xmlReader = $this->getInternalXmlReader($configReader);`
`179`	`181`
`180`	`182`	`$this->setExpectedException('PHPUnit_Framework_Error_Warning');`
	`183`	`+`
	`184`	`+ // following operation should fail because the internal reader is closed (and expected to be closed)`
`181`	`185`	`$xmlReader->setParserProperty(XMLReader::VALIDATE, true);`
`182`	`186`	`}`
`183`	`187`