Merge pull request zendframework/zendframework#5068 from heik/master

weierophinney · weierophinney · commit 0a4d9f491c91 · 2013-09-04T09:33:05.000-05:00
using injected response object
diff --git a/src/Client.php b/src/Client.php
@@ -905,7 +905,7 @@ public function send(Request $request = null)
                     $response->setCleanup(true);
                 }
             } else {
-                $response = Response::fromString($response);
+                $response = $this->getResponse()->fromString($response);
             }
 
             // Get the cookies from response (if any)
diff --git a/test/ClientTest.php b/test/ClientTest.php
@@ -349,4 +349,48 @@ public function testAdapterAlwaysReachableIfSpecified()
 
         $this->assertSame($testAdapter, $client->getAdapter());
     }
+
+    /**
+     * Custom response object is set but still invalid code coming back
+     * @expectedException Zend\Http\Exception\InvalidArgumentException
+     */
+    public function testUsageOfCustomResponseInvalidCode()
+    {
+        require_once(dirname(realpath(__FILE__)) . DIRECTORY_SEPARATOR .'_files' . DIRECTORY_SEPARATOR . 'CustomResponse.php');
+        $testAdapter = new Test();
+        $testAdapter->setResponse(
+            "HTTP/1.1 496 CustomResponse\r\n\r\n"
+            . "Whatever content"
+        );
+
+        $client = new Client('http://www.example.org/', array(
+            'adapter' => $testAdapter,
+        ));
+        $client->setResponse(new CustomResponse());
+        $response = $client->send();
+    }
+
+    /**
+     * Custom response object is set with defined status code 497.
+     * Should not throw an exception.
+     */
+    public function testUsageOfCustomResponseCustomCode()
+    {
+        require_once(dirname(realpath(__FILE__)) . DIRECTORY_SEPARATOR .'_files' . DIRECTORY_SEPARATOR . 'CustomResponse.php');
+        $testAdapter = new Test();
+        $testAdapter->setResponse(
+            "HTTP/1.1 497 CustomResponse\r\n\r\n"
+            . "Whatever content"
+        );
+
+        $client = new Client('http://www.example.org/', array(
+            'adapter' => $testAdapter,
+        ));
+        $client->setResponse(new CustomResponse());
+        $response = $client->send();
+
+        $this->assertInstanceOf('ZendTest\Http\CustomResponse', $response);
+        $this->assertEquals(497, $response->getStatusCode());
+        $this->assertEquals('Whatever content', $response->getContent());
+    }
 }
diff --git a/test/_files/CustomResponse.php b/test/_files/CustomResponse.php
@@ -0,0 +1,7 @@
+<?php
+namespace ZendTest\Http;
+
+class CustomResponse extends \Zend\Http\Response
+{
+    const STATUS_CODE_497 = 497;
+}

Original file line number	Diff line number	Diff line change
`@@ -905,7 +905,7 @@ public function send(Request $request = null)`
`905`	`905`	`$response->setCleanup(true);`
`906`	`906`	`}`
`907`	`907`	`} else {`
`908`		`- $response = Response::fromString($response);`
	`908`	`+ $response = $this->getResponse()->fromString($response);`
`909`	`909`	`}`
`910`	`910`
`911`	`911`	`// Get the cookies from response (if any)`