ClassMethods Hydrator ignores invalid values

prolic · prolic · commit 30aa565efaff · 2012-05-31T15:29:21.000+02:00
diff --git a/src/Hydrator/ClassMethods.php b/src/Hydrator/ClassMethods.php
@@ -120,7 +120,9 @@ public function hydrate(array $data, $object)
                 $property = preg_replace_callback('/(_[a-z])/', $transform, $property);
             }
             $method = 'set' . ucfirst($property);
-            $object->$method($value);
+            if (method_exists($object, $method)) {
+                $object->$method($value);
+            }
         }
         return $object;
     }
diff --git a/test/HydratorTest.php b/test/HydratorTest.php
@@ -37,6 +37,22 @@
  */
 class HydratorTest extends \PHPUnit_Framework_TestCase
 {
+
+    /**
+     * @var ClassMethodsCamelCase
+     */
+    protected $classMethodsCamelCase;
+
+    /**
+     * @var ClassMethodsCamelCaseMissing
+     */
+    protected $classMethodsCamelCaseMissing;
+
+    /**
+     * @var ClassMethodsUnderscore
+     */
+    protected $classMethodsUnderscore;
+
     public function setUp()
     {
         $this->classMethodsCamelCase = new ClassMethodsCamelCase();
@@ -93,4 +109,16 @@ public function testHydratorClassMethodsUnderscore()
         $this->assertEquals($test->getFooBar(), 'foo');
         $this->assertEquals($test->getFooBarBaz(), 'bar');
     }
+
+    public function testHydratorClassMethodsIgnoresInvalidValues()
+    {
+        $hydrator = new ClassMethods(false);
+        $data = array(
+            'foo_bar' => '1',
+            'foo_bar_baz' => '2',
+            'invalid' => 'value'
+        );
+        $test = $hydrator->hydrate($data, $this->classMethodsUnderscore);
+        $this->assertSame($this->classMethodsUnderscore, $test);
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,9 @@ public function hydrate(array $data, $object)`
`120`	`120`	`$property = preg_replace_callback('/(_[a-z])/', $transform, $property);`
`121`	`121`	`}`
`122`	`122`	`$method = 'set' . ucfirst($property);`
`123`		`- $object->$method($value);`
	`123`	`+ if (method_exists($object, $method)) {`
	`124`	`+ $object->$method($value);`
	`125`	`+ }`
`124`	`126`	`}`
`125`	`127`	`return $object;`
`126`	`128`	`}`