From fe3682859ff0f8f1fc945bc408cfa954cc59f2b8 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Sat, 31 Aug 2013 17:07:01 +0700 Subject: [PATCH 1/3] add test case for Zend\Validator\IsInstanceOf for pass Traversable to __construct --- tests/ZendTest/Validator/IsInstanceOfTest.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/ZendTest/Validator/IsInstanceOfTest.php b/tests/ZendTest/Validator/IsInstanceOfTest.php index 71c2b7f1875..36882dc145a 100644 --- a/tests/ZendTest/Validator/IsInstanceOfTest.php +++ b/tests/ZendTest/Validator/IsInstanceOfTest.php @@ -96,4 +96,10 @@ public function testEqualsMessageVariables() $validator->getOption('messageVariables') ); } + + public function testPassTraversableToConstructor() + { + $validator = new Validator\IsInstanceOf(new \ArrayIterator(array('className' => 'DateTime'))); + $this->assertEquals('DateTime', $validator->getClassName()); + } } From 0d9e5d59a6a721f2065c0c04d8de5143cccf4b4d Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Sat, 31 Aug 2013 17:15:18 +0700 Subject: [PATCH 2/3] add for isValid() --- tests/ZendTest/Validator/IsInstanceOfTest.php | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/ZendTest/Validator/IsInstanceOfTest.php b/tests/ZendTest/Validator/IsInstanceOfTest.php index 36882dc145a..f5eff811eec 100644 --- a/tests/ZendTest/Validator/IsInstanceOfTest.php +++ b/tests/ZendTest/Validator/IsInstanceOfTest.php @@ -101,5 +101,6 @@ public function testPassTraversableToConstructor() { $validator = new Validator\IsInstanceOf(new \ArrayIterator(array('className' => 'DateTime'))); $this->assertEquals('DateTime', $validator->getClassName()); + $this->assertTrue($validator->isValid(new DateTime())); } } From 8c3b0a82df9dd64c760f611ff892170e77262823 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Sun, 1 Sep 2013 02:21:14 +0700 Subject: [PATCH 3/3] fix space and added invalid instance to be tested --- tests/ZendTest/Validator/IsInstanceOfTest.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/ZendTest/Validator/IsInstanceOfTest.php b/tests/ZendTest/Validator/IsInstanceOfTest.php index f5eff811eec..de89628255e 100644 --- a/tests/ZendTest/Validator/IsInstanceOfTest.php +++ b/tests/ZendTest/Validator/IsInstanceOfTest.php @@ -99,8 +99,10 @@ public function testEqualsMessageVariables() public function testPassTraversableToConstructor() { - $validator = new Validator\IsInstanceOf(new \ArrayIterator(array('className' => 'DateTime'))); + $validator = new Validator\IsInstanceOf(new \ArrayIterator(array('className' => 'DateTime'))); $this->assertEquals('DateTime', $validator->getClassName()); $this->assertTrue($validator->isValid(new DateTime())); + $this->assertFalse($validator->isValid(null)); + $this->assertFalse($validator->isValid($this)); } }