Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jan 8, 2020. It is now read-only.

Fixed the pre-commit script, missed the fix command#3029

Closed
ezimuel wants to merge 1 commit into
zendframework:masterfrom
ezimuel:hotfix/pre-commit
Closed

Fixed the pre-commit script, missed the fix command#3029
ezimuel wants to merge 1 commit into
zendframework:masterfrom
ezimuel:hotfix/pre-commit

Conversation

@ezimuel
Copy link
Copy Markdown
Contributor

@ezimuel ezimuel commented Nov 20, 2012

Fixed the syntax of php-cs-fixer, missed the fix command:
php-cs-fixer --dry-run --level=psr2 fix

@Slamdunk
Copy link
Copy Markdown
Contributor

The command should be the first argument after executable:

exec("php-cs-fixer fix --dry-run --level=psr2 " . escapeshellarg($fileName), $output, $return);

weierophinney added a commit that referenced this pull request Nov 20, 2012
- Moved to after command, but before options
weierophinney added a commit that referenced this pull request Nov 20, 2012
@Slamdunk
Copy link
Copy Markdown
Contributor

@weierophinney As I wrote previously, you've merged a bugged bugfix

@Maks3w
Copy link
Copy Markdown
Member

Maks3w commented Nov 20, 2012

@Slamdunk See 09dc602 @weierophinney read your comment before merge

@ghost ghost assigned weierophinney Nov 20, 2012
@Slamdunk
Copy link
Copy Markdown
Contributor

Commits mixing is not so clear while merging, sry if I didn't see that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants