This repository was archived by the owner on Jan 8, 2020. It is now read-only.
Hotfix/session mutability#3452
Merged
Maks3w merged 4 commits intoJan 16, 2013
Merged
Conversation
…estructor - Fixed an issue where an exception was not properly defined in use - Fixed a flash messenger test by clearing session storage on teardown - Removed a no longer valid test on sessionmanagertest Conflicts: library/Zend/Session/Storage/SessionArrayStorage.php
- which allows creating the internally used Container with the specified session manager - neither FM and PRG should instantiate a SessionManager directly; they should use the default manager from the Container class
- Created docblock for __invoke() method - Removed an else condition that would not be hit if the if condition is evaluated.
- An import of "use Zend\Session\Storage\StorageInterface as Storage" caused a subsequent, existing check of "instanceof Storage\StorageInterface" to thus fail. Removed all imports for classes in the same namespace to fix the issue.
Member
Author
|
To whomever reviews this: please merge against both master and develop, as the issue presents in both branches. |
gianarb
pushed a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
…ssion-mutability'
gianarb
pushed a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
Conflicts: library/Zend/Mvc/Controller/Plugin/PostRedirectGet.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues introduced earlier this week when we added the ability to call the session's writeClose() method on shutdown. Doing it in
__destructcaused issues, so @mwillbanks has moved it to aregister_shutdown_function, which ensures the original issue is fixed, while simultaneously fixing the regression.In this PR, I also made it possible to inject the PRG plugin with a session manager, to make mocking and test isolation easier.