Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jan 8, 2020. It is now read-only.

Added new option to fix a little issue originated from last PR#3844

Closed
iquabius wants to merge 3 commits into
zendframework:masterfrom
iquabius:fix-identical-validator
Closed

Added new option to fix a little issue originated from last PR#3844
iquabius wants to merge 3 commits into
zendframework:masterfrom
iquabius:fix-identical-validator

Conversation

@iquabius
Copy link
Copy Markdown
Contributor

@iquabius iquabius commented Feb 21, 2013

After I sent this PR, I realised a little problem:
When identical validator is used in a form scope, the form will always provide a context, because of this, it wouldn't be possible to validate a literal token, see the example.

use Zend\Form\Form;
use Zend\InputFilter\InputFilter;

$form = new Form('form');
$form->add(array(
    'name' => 'humanCheck',
    'options' => array(
        'label' => 'How much is 1 + 2?',
    ),
));

$inputFilter = new InputFilter();
$inputFilter->add(array(
    'name' => 'humanCheck',
    'required' => true,
    'validators' => array(
        array(
            'name' => 'Identical',
            'options' => array(
                'token' => '3',
            ),
        ),
    ),
));

$form->setInputFilter($inputFilter);
...

This would not work because on validation the validator would try to find '3' in the context, and then rise an exception when it doesn't find it.

To solve this I add a new option, literal. Setting this to true (it's false by default) would allow a 'literal' validation even when the context is provided. So the above input filter would look like this:

$inputFilter->add(array(
    'name' => 'humanCheck',
    'required' => true,
    'validators' => array(
        array(
            'name' => 'Identical',
            'options' => array(
                'literal' => true,
                'token' => '3',
            ),
        ),
    ),
));

This would tell the validator to skip the look up in the context and just use the string '3'.
_Note: this option has no affect when context is not provided._

blanchonvincent
blanchonvincent reviewed Feb 21, 2013
View reviewed changes
Comment thread library/Zend/Validator/Identical.php
Copy link
Copy Markdown
Contributor

@blanchonvincent blanchonvincent Feb 21, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you add a space ?

Copy link
Copy Markdown
Contributor Author

@iquabius iquabius Feb 21, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To align with the line below!

@iquabius
Copy link
Copy Markdown
Contributor Author

iquabius commented Feb 22, 2013

@bakura10 sent this PR (#3869), to fix a BC break originated from this PR (#3803). If his PR is really necessary, this one isn't.

I think this new option is a good idea, if it can't be in this version, it could be added in some next version (from what I see just in ZF 3.0, right!?)

So someone take a good look and decide what is the best solution!

@iquabius iquabius mentioned this pull request Feb 22, 2013
Closed
@bakura10
Copy link
Copy Markdown
Contributor

bakura10 commented Feb 22, 2013

I think we need to merge my PR, yours still introduce a BC that is not necessary. As you said, you need to keep this for ZF 3 :).

@Freeaqingme
Copy link
Copy Markdown
Member

Freeaqingme commented Mar 6, 2013

As per the comments, I'll assign this issue to version 3.0.0, that will give us plenty of time to think about it and review it ;)

Nonetheless I'd like to thank you for your PR, we have plenty of other issues that you may be willing to work on in the meanwhile! =)

@weierophinney
Copy link
Copy Markdown
Member

weierophinney commented Mar 25, 2013

I think I'm missing something; I don't see anything backwards incompatible in this PR. I think we can merge this for 2.2.0.

@ghost ghost assigned weierophinney Mar 25, 2013
weierophinney added a commit that referenced this pull request Mar 25, 2013
@weierophinney
Merge pull request #3844 from wryck7/fix-identical-validator
b642d83 
Added new option to fix a little issue originated from last PR

Conflicts:
	tests/ZendTest/Validator/IdenticalTest.php
weierophinney added a commit that referenced this pull request Mar 25, 2013
@weierophinney
[#3844] Remove tests no longer present in develop
a1512a7 
- Two tests were present on master but removed in develop -- and brought
  back in during merge. Removed.
weierophinney added a commit that referenced this pull request Mar 25, 2013
@weierophinney
Merge branch 'feature/3844' into develop
9c848db 
Close #3844
@iquabius
Copy link
Copy Markdown
Contributor Author

iquabius commented Mar 26, 2013

The BC break was fixed with @bakura10's PR. When I first introduced the ability to validate in fieldsets, the line 174 was throwing an exeption - that happened in the case a $context was provided and the given token didn't existed. Now the behavior is to use the token literally if this happens - the bad thing about this is that if you type a wrong token, you will never know why your fields are not validating, but this was necessary to remove the BC break.

I actually didn't realize this PR could still be used.

@weierophinney
Copy link
Copy Markdown
Member

weierophinney commented Mar 27, 2013

Forgot to close when I merged!

@iquabius iquabius deleted the fix-identical-validator branch March 27, 2013 21:57
@iquabius iquabius mentioned this pull request Apr 6, 2013
Merged
weierophinney added a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
@weierophinney
Merge pull request zendframework/zendframework#3844 from wryck7/fix-i…
295f526 
…dentical-validator

Added new option to fix a little issue originated from last PR

Conflicts:
	tests/ZendTest/Validator/IdenticalTest.php
weierophinney added a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
@weierophinney
[zendframework/zendframework#3844] Remove tests no longer present in …
7195a53 
…develop

- Two tests were present on master but removed in develop -- and brought
  back in during merge. Removed.
weierophinney added a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
@weierophinney
Merge branch 'feature/3844' into develop
963d2fe 
Close zendframework/zendframework#3844
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@weierophinney weierophinney

Labels

None yet

Projects

None yet

Milestone

2.2.0

Development

Successfully merging this pull request may close these issues.

5 participants

@iquabius @bakura10 @Freeaqingme @weierophinney @blanchonvincent