Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jan 8, 2020. It is now read-only.

Check if values are set in Zend\Db\Sql\Insert.php for prepared statement#3849

Merged
ralphschindler merged 3 commits into
zendframework:masterfrom
cdekok:master
Mar 13, 2013
Merged

Check if values are set in Zend\Db\Sql\Insert.php for prepared statement#3849
ralphschindler merged 3 commits into
zendframework:masterfrom
cdekok:master

Conversation

@cdekok
Copy link
Copy Markdown
Contributor

@cdekok cdekok commented Feb 21, 2013

Check if values are set in Send\Db\Sql\Insert

Fixes code for..

$dbConnection->beginTransaction();
$columns = array('title', 'description');
$values = array(
 'Test',
 'Test'
);
$insert = $sql->insert()->columns($columns);
$stmt = $sql->prepareStatementForSqlObject($insert);            
$stmt->execute($values);
``

Issue here: https://github.com/zendframework/zf2/issues/3847

@cdekok cdekok mentioned this pull request Feb 21, 2013
Closed
@Freeaqingme
Copy link
Copy Markdown
Member

Freeaqingme commented Mar 6, 2013

@mech7 Thank you for your pull request. Could you please also add a unit test that demonstrates the new behavior and therewith preventing regressions? Thanks!

=> Assigning to @ralphschindler cause he knows every little detail about zend\db.

@ghost ghost assigned ralphschindler Mar 6, 2013
@cdekok
Copy link
Copy Markdown
Contributor Author

cdekok commented Mar 7, 2013

Ok I will try I am not an expert at unit testing, I cannot replicate it with the mock object that the test is currently using.

@Freeaqingme
Copy link
Copy Markdown
Member

Freeaqingme commented Mar 7, 2013

@mech7 That's no problem at all! If you feel you need help, please feel free to join us on IRC on #zftalk.dev, alternatively you could send a mail to the cr team ( zf-crteam [at] zend ) for some assistance.

@cdekok
Copy link
Copy Markdown
Contributor Author

cdekok commented Mar 7, 2013

@Freeaqingme Thanks but i figured it out I think :) Hope this is ok.. you can see it will throw some notices when running the test without the fix.

@ralphschindler ralphschindler merged commit c1a7f89 into zendframework:master Mar 13, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@ralphschindler ralphschindler

Labels

Db

Projects

None yet

Milestone

2.1.4

Development

Successfully merging this pull request may close these issues.

3 participants

@cdekok @Freeaqingme @ralphschindler