Fix #4051 console::writeLine() #4055
Conversation
There was a problem hiding this comment.
Why not simply use iconv_substr() here (which is built into PHP), and get red of that if statement for mbstring?
|
@DASPRiD mbstring are 5-10x faster than iconv. |
|
Then why don't you use Zend\Stdlib\StringUtils::getWrapper(), it will automatically select the available wrapper for you. This would reduce duplicate code, right? |
|
When |
|
@DASPRiD done. |
|
@weierophinney @DASPRiD I've got a pickle here. The original ("ambitious") implementation of The problem is that people also use As much as I like my original idea I believe the benefits do not outweight the cost needed to work around the above problem. In case someone wanted to do I think the best option here is to remove the feature of matching input with console width and instead implement the standard Comments ? |
|
@Thinkscape I'm in agreement. Does that need to be done prior to merging this? |
… length to console width.
Fix #4051 console::writeLine()
…otfix/console-writeline Fix zendframework/zendframework#4051 console::writeLine()
This fixes issue #4051