This repository was archived by the owner on Jan 8, 2020. It is now read-only.
CollectionInputFilter should respect the keys of collectionData#4516
Closed
zluiten wants to merge 1 commit into
Closed
CollectionInputFilter should respect the keys of collectionData#4516zluiten wants to merge 1 commit into
zluiten wants to merge 1 commit into
Conversation
… have to be consecutive
Member
|
@davidwindell - As the CollectionInputFilter was your addition, mind weighing in? @Netiul If David approves, I would consider this a bugfix; as such, do you mind if I cherry pick it into master for 2.2.1? Authorship is retained; the history changes, though, so you'll have to update your branch after I merge. |
Contributor
|
@weierophinney sure thing, I'll run this through our app tomorrow which has additional extensive tests involving the component and provide any feedback. |
Contributor
Author
|
@weierophinney, no problem |
Contributor
|
Looks good to me 👍 thanks @Netiul |
Contributor
Author
|
Thanks for reviewing @davidwindell |
weierophinney
added a commit
to zendframework/zend-inputfilter
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-inputfilter
that referenced
this pull request
May 15, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the CollectionInputFilter assumes that collectionData has always consecutive array keys which can be wrong.
Two changes
$this->countis set to, just mark the collection as invalid, since it doesn't make sense to add them to invalidInputs when there is no corresponding set of data.